Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor bug in delete_nodes utility due to typo #1565

Merged

Conversation

sphuber
Copy link
Contributor

@sphuber sphuber commented May 22, 2018

Fixes #1564

Added a test that would have caught this bug. For this it was
necessary to set the verbosity to 2, because the bug was only
triggered in the branches of code for high verbosity. Additionally,
the tests created a simple graph of base Node instances, which
means that the logic involving Calculation nodes and CALL links
was not hit. The new test explicitly creates Calculation nodes with
CALL links to test this case

Added a test that would have caught this bug. For this it was
necessary to set the verbosity to 2, because the bug was only
triggered in the branches of code for high verbosity. Additionally,
the tests created a simple graph of base Node instances, which
means that the logic involving Calculation nodes and CALL links
was not hit. The new test explicitly creates Calculation nodes with
CALL links to test this case
@codecov-io
Copy link

Codecov Report

Merging #1565 into develop will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1565      +/-   ##
===========================================
+ Coverage     56.9%   56.96%   +0.05%     
===========================================
  Files          273      273              
  Lines        33862    33862              
===========================================
+ Hits         19270    19288      +18     
+ Misses       14592    14574      -18
Impacted Files Coverage Δ
aiida/utils/delete_nodes.py 78.04% <ø> (+21.95%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd6b397...7b81593. Read the comment docs.

@sphuber sphuber merged commit 6a1bd32 into aiidateam:develop May 22, 2018
@sphuber sphuber deleted the fix_1563_verdi_node_delete_develop branch May 22, 2018 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants