Fix minor bug in delete_nodes utility due to typo #1564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## release_v0.12.1 #1564 +/- ##
===================================================
+ Coverage 54.63% 54.68% +0.05%
===================================================
Files 246 246
Lines 32419 32419
===================================================
+ Hits 17711 17729 +18
+ Misses 14708 14690 -18
Continue to review full report at Codecov.
|
Added a test that would have caught this bug. For this it was necessary to set the verbosity to 2, because the bug was only triggered in the branches of code for high verbosity. Additionally, the tests created a simple graph of base Node instances, which means that the logic involving Calculation nodes and CALL links was not hit. The new test explicitly creates Calculation nodes with CALL links to test this case
sphuber
force-pushed
the
fix_1563_verdi_node_delete
branch
from
1085427
to
2d4d86b
Compare
giovannipizzi
approved these changes
May 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1563
Added a test that would have caught this bug. For this it was
necessary to set the verbosity to 2, because the bug was only
triggered in the branches of code for high verbosity. Additionally,
the tests created a simple graph of base Node instances, which
means that the logic involving Calculation nodes and CALL links
was not hit. The new test explicitly creates Calculation nodes with
CALL links to test this case