Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

button: Add guidance about customising loadingLabel #1915

Merged
merged 3 commits into from
Dec 19, 2024
Merged

button: Add guidance about customising loadingLabel #1915

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
459ef0a
loading state property update
adrian-yee Dec 16, 2024
c4b0bd4
Update packages/react/src/button/docs/overview.mdx
stowball Dec 19, 2024
2e0a11c
Create large-eels-push.md
stowball Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/large-eels-push.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@ag.ds-next/react": patch
---

button: Add guidance about customising `loadingLabel`.
1 change: 1 addition & 0 deletions packages/react/src/button/docs/overview.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ Make sure you include a [meaningful text label](/components/button/rationale#mea
- create a meaningful button label with a verb and a noun that makes the action obvious to all users - e.g. ‘Register establishment’
- avoid general labels that don’t provide full context. - e.g. ‘Click here’
- use the `loading` property to let users know their action is being processed
- customise the `loadingLabel` property announcement to make it more contextual
- add an icon if it helps users understand the action, and only in conjunction with a text label
- use only one Primary button on a page. You can use more than one Secondary or Tertiary button.

Expand Down
Loading