Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

button: Add guidance about customising loadingLabel #1915

Merged
merged 3 commits into from
Dec 19, 2024
Merged

Conversation

adrian-yee
Copy link
Contributor

@adrian-yee adrian-yee commented Dec 16, 2024

button: Add guidance about customising loadingLabel.

View preview

Checklist

Preflight

  • Prefix the PR title with the slug of the package or component - e.g. accordion: Updated padding or docs: Updated header links
  • Describe the changes clearly in the PR description
  • Read and check your code before tagging someone for review
  • Create a changeset file by running yarn changeset. Learn more about change management.

Testing

  • Manually test component in various modern browsers at various sizes (use Browserstack)
  • Manually test component in various devices (phone, tablet, desktop)
  • Manually test component using a keyboard
  • Manually test component using a screen reader
  • Manually tested in dark mode
  • Component meets Web Content Accessibility Guidelines (WCAG) 2.1 standards
  • Add any necessary unit tests (HTML validation, snapshots etc)
  • Run yarn test to ensure tests are passing. If required, run yarn test -u to update any generated snapshots.

Documentation

  • Create or update documentation on the website
  • Create or update stories for Storybook
  • Create or update stories for Playroom snippets

added do content to customise loading announcement
Copy link

changeset-bot bot commented Dec 16, 2024

🦋 Changeset detected

Latest commit: 2e0a11c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ag.ds-next/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 16, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-12-19 22:56 UTC

@stowball stowball changed the title loading state property update button: Add guidance about customising loadingLabel Dec 19, 2024
@stowball stowball merged commit 2fff6d2 into main Dec 19, 2024
8 checks passed
@stowball stowball deleted the adrian-yee-patch-1 branch December 19, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants