-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Licensed Health Care Facilities from Dept of Health #257
Comments
It seems a little odd to me to use the same table name in the deprecation and addition since any existing references will still be correct but the schema will be completely incompatible. I'm not sure what the best advice is on the naming since the current name is ideal but it should change. |
Definitely not ideal but we have done it in the past with Soils. I haven't been able to dream up a name that's more descriptive than HealthCareFacilities. |
We had a similar conversion with soils and the situation was a little different. This is worth a group discussion to come up with a consistent path forward for this occurrence and all future ones. |
I added a discussion item in tomorrow's team meeting. |
@steveoh do we have any metrics on open-sgid tracking what gets used and how often? In deprecation/addition cases where the schema changes but the name stays the same we decided to add |
We sorta do but no there isn't. Everyone has access to view all the data available for the cloudsql instance. To read between the lines, there should be a consistent process independent of popularity.
I thought the soft delete unshared the item/deleted the table? What does renaming the table accomplish differently? Would that only work for open data/arcgis online? The open sgid connection will break during the soft delete, like it normally would, and will look correct after the same table name is added again. How does Any api search requests or open sgid layer in a project that goes unnoticed, and let's be honest, our reach for these deprecations is not great, will query the same table the entire time. The error message in the api will change from this table doesn't exist, which is correct, to this attribute doesn't exist on this table, which is confusing. I'm not sure what pro/map/qgis/etc would do. This seems like a poor solution that I can't support since it doesn't cover all of the sgid. Suffixing the table with |
I think a deprecation/addition with the same name, though not ideal, is a fact of life. To me having intuitive naming conventions that make sense is better in the long run and make up for whatever short term disruption that a user experiences. Adding I think appending new fields on to the existing schema isn't a viable solution. That leaves us either trying to maintain fields that no longer exist in the stewards data or having columns in the table that only have null values. It sounds like this needs to be discussed at the next dev/data meeting. |
conductor results for tasks - 257
|
conductor results for tasks - 257
|
2 similar comments
conductor results for tasks - 257
|
conductor results for tasks - 257
|
conductor results for tasks - 257
|
Adding blocked since work hasn't started on this yet. |
Waiting on updated facilities from Health. |
conductor results for tasks - 257
|
This does not yet have a record series, I will find out how to create one |
conductor results for tasks - 257
|
1 similar comment
conductor results for tasks - 257
|
conductor results for tasks - 257
|
conductor results for tasks - 257
|
conductor results for tasks - 257
|
conductor results for HEALTH.LicensedHealthCareFacilities
|
conductor results for tasks - 257
|
conductor results for HEALTH.LicensedHealthCareFacilities
|
conductor results for tasks - 257
|
conductor results for HEALTH.LicensedHealthCareFacilities
|
@brigsz is there a process or receommendation for this yet? |
conductor results for tasks - 257
|
conductor results for HEALTH.LicensedHealthCareFacilities
|
This is now complete |
Summary
This will replace the existing, soon to be deprecated SGID.HEALTH.HealthCareFacilities. This data has been geocoded from licensed health providers and will have the same source as the current HealthCareFacilities but a different schema that will be easier to maintain.
The data should be available in
1 Check [x] all the areas where you expect the data to show up.
The data is of high quality
2024/07/02
)2024/07/02
)2024/07/02
)Where is the data source
Choose one.
Action items
name
with their github@name
.Strikeout all items that do not apply.2024/07/02
)[ ] Configure forklift for Farm from AGOL (name, completed:2022/00/00
)2024/07/22
)2024/07/02
)SGID.META.AGOLItems
record (@ZachBeck2024/07/02
)[ ] Complete an AGOLItems_shelved record for anystatic
orshelved
item (name, completed:2022/00/00
)2024/08/06
)2024/07/29
)🤖 Automation validation
name
with their github@name
.2020/01/01
when the task is verified.Strikeout all items that do not apply.2024/07/08
)2022/07/08
)2024/07/04
)2024/07/08
)2024/08/07
)2024/07/15
)Notification
Group Task Assignments
The text was updated successfully, but these errors were encountered: