Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(lint): make tolerant of deprecations #422

Merged
merged 1 commit into from
Aug 4, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@ jobs:
golangci:
name: golangci-lint
runs-on: ubuntu-latest
strategy:
matrix:
mode: [no-failure, no-deprecations]
steps:
- uses: actions/setup-go@v3
with:
Expand All @@ -24,3 +27,6 @@ jobs:
with:
# Optional: version of golangci-lint to use in form of v1.2 or v1.2.3 or `latest` to use the latest version
version: v1.49.0
args: --exclude=nolintlint
${{ matrix.mode == 'no-deprecations' && '--exclude=SA1019:' || '' }}
${{ matrix.mode == 'no-failure' && '--issues-exit-code=0' || '' }}
3 changes: 2 additions & 1 deletion .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@ linters:
- ineffassign
- misspell
- nakedret
- nolintlint
# [AGORIC] Caused false-positives
# - nolintlint
- staticcheck
- stylecheck
- typecheck
Expand Down
Loading