Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(lint): make tolerant of deprecations #422

Merged
merged 1 commit into from
Aug 4, 2024
Merged

ci(lint): make tolerant of deprecations #422

merged 1 commit into from
Aug 4, 2024

Conversation

michaelfig
Copy link
Collaborator

@michaelfig michaelfig commented Aug 3, 2024

Refs: Agoric/agoric-sdk#8866

Description

Port of the Agoric/agoric-sdk#8866 PR to relax the Golang lint treatment until we upgrade to a version of Cosmos SDK that doesn't use deprecated dependencies.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@michaelfig michaelfig self-assigned this Aug 3, 2024
@michaelfig michaelfig force-pushed the mfig-ci-lint branch 8 times, most recently from 9b3fb4b to 030e542 Compare August 3, 2024 02:33
@michaelfig michaelfig marked this pull request as ready for review August 3, 2024 02:33
@michaelfig michaelfig requested review from gibson042 and mhofman August 3, 2024 02:44
Base automatically changed from mfig-v0.46.16-alpha.agoric.2.4 to Agoric August 4, 2024 06:25
@michaelfig michaelfig merged commit 2c7e403 into Agoric Aug 4, 2024
26 checks passed
@michaelfig michaelfig deleted the mfig-ci-lint branch August 4, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants