Add precission property to renderer component #3989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmarcos
force-pushed
the
fixAdreno
branch
2 times, most recently
from
2c5e6f4 to
dd04a6a
Compare
ngokevin
reviewed
Feb 1, 2019
docs/components/renderer.md
Outdated
| @@ -32,6 +32,7 @@ The `renderer` system configures a scene's | |||
| | maxCanvasWidth | Maximum canvas width. Uses the size multiplied by device pixel ratio. Does not limit canvas width if set to -1. | 1920 | | |||
| | maxCanvasHeight | Maximum canvas height. Behaves the same as maxCanvasWidth. | 1920 | | |||
| | logarithmicDepthBuffer | Whether to use a logarithmic depth buffer. | auto | | |||
| | precision | Shader Precision | high | | |||
There was a problem hiding this comment.
should describe it more here, what it does, including the options. I'd almost just shove the whole paragraph from below into here, or at least link it.
|
r+wc |
dmarcos
force-pushed
the
fixAdreno
branch
2 times, most recently
from
14ffb98 to
854b0c5
Compare
… with Adreno 300 series GPUs and improves perf. (fix aframevr#3971, aframevr#3523)
This was referenced Feb 3, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting
mediumpin mobile by defult resulted in very noticeable visual artifacts. It's better if the developers can set the value deliberately knowing the trade offs.