Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set shader precission to mediump in Mobile with no native VR. Fix problems with Adreno 300 series GPUs and improves perf. (fix #3971, #3523) #3977

Merged
merged 1 commit into from
Jan 31, 2019
Merged

Set shader precission to mediump in Mobile with no native VR. Fix problems with Adreno 300 series GPUs and improves perf. (fix #3971, #3523) #3977

merged 1 commit into from
Jan 31, 2019

Conversation

dmarcos
Copy link
Member

@dmarcos dmarcos commented Jan 30, 2019 •
edited
Loading

This will also improve perf on mobile across the board. There might be visual differences (mrdoob/three.js#14570). Is tradeoff worth it?

@dmarcos
Set shader precission to mediump on mobile with no native VR. Fix pro…
0333a2c 
…blems with Adreno 300 series GPUs and improves perf. (fix aframevr#3971, aframevr#3523)
@dmarcos dmarcos changed the title Set shader precission to mediump in Mobile. Fix problems with Adreno 300 series GPUs and improves perf. (fix #3971, #3523) Set shader precission to mediump in Mobile with no native VR. Fix problems with Adreno 300 series GPUs and improves perf. (fix #3971, #3523) Jan 30, 2019
@ngokevin ngokevin merged commit 8481314 into aframevr:master Jan 31, 2019
@dmarcos
Copy link
Member Author

dmarcos commented Jan 31, 2019

This was not ready

@dmarcos dmarcos mentioned this pull request Jan 31, 2019
Merged
@ngokevin
Copy link
Member

You can indicate with a WIP tag.

This was referenced Feb 3, 2019
Closed
Closed
@gabrielgrant
Copy link

For future reference, this change was reverted via #3988 and then a precision prop was added instead in #3989

@dmarcos dmarcos mentioned this pull request Apr 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs answers / feedback
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dmarcos @ngokevin @gabrielgrant