Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new testJobType for release #849

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Conversation

smlambert
Copy link
Contributor

@smlambert smlambert commented Nov 28, 2023

Fixes #847
Add an explicit testJobType for release pipeline, which allows us to add non-blocking testing to weekly runs

Signed-off-by: Shelley Lambert <[email protected]>
Copy link

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,21"

@github-actions github-actions bot added documentation generation Issues that provide enhancements or fixes to the job generators jenkins-pipeline testing labels Nov 28, 2023
@karianna
Copy link
Contributor

@smlambert

RepoHandlerTest > adoptDefaultsGetterReturns() FAILED
org.opentest4j.AssertionFailedError: expected: but was:
at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:40)
at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:35)
at org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:162)
at org.junit.jupiter.api.Assertions$assertTrue$1.call(Unknown Source)
at org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:47)
at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:125)
at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:139)
at RepoHandlerTest.adoptDefaultsGetterReturns(RepoHandlerTest.groovy:70)

@smlambert
Copy link
Contributor Author

smlambert commented Dec 7, 2023

@karianna - Looking at https://github.com/adoptium/ci-jenkins-pipelines/blob/master/docs/UsingOurScripts.md#this-is-great-but-how-do-i-add-new-defaults , it is expected that a newly added test will fail.

You may find that the RepoHandlerTest.groovy:adoptDefaultsGetterReturns() will fail when you add new values. This is expected as the test is pulling in Adopt's master branch defaults.json which does not yet contain the new values. Please inform any reviewers of this in the pull request.

@smlambert smlambert requested review from sophia-guo and andrew-m-leonard and removed request for andrew-m-leonard December 7, 2023 13:13
Copy link
Contributor

@andrew-m-leonard andrew-m-leonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good I think

Copy link
Contributor

@sophia-guo sophia-guo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smlambert
Copy link
Contributor Author

I will proceed to merge, and monitor the next PR test runs on a different PR, to ensure these new tests are "good".

@smlambert smlambert merged commit 8f6ba6d into adoptium:master Dec 7, 2023
7 of 8 checks passed
luhenry pushed a commit to luhenry/adoptium-ci-jenkins-pipelines that referenced this pull request Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation generation Issues that provide enhancements or fixes to the job generators jenkins-pipeline testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create new testJobType='release'
4 participants