issue #41 issue #45 Enable tests on windows #46
Conversation
|
Jenkins build current have two other issues:
All is good. Ask for deliver those fixes first and open specific issues and investigate. |
| JAVA_BIN='$WORKSPACE/openjdkbinary/j2sdk-image/jre/bin' | ||
| JCL_VERSION='current' | ||
| OPENJDK_TEST='$WORKSPACE/openjdk-test' | ||
| JAVA_BIN='C:/Users/jenkins/workspace/openjdk_test_x86-64_windows/openjdkbinary/j2sdk-image/jre/bin' |
There was a problem hiding this comment.
worth putting C:/Users/jenkins/workspace/openjdk_test_x86-64_windows into a var?
There was a problem hiding this comment.
See issue #41 for jenkins there is an environment variable for this value WORKSPACE. However it doesn't work for jenkins pipeline environment section on windows. So this is temporary solution. Eventually we'd like using WORKSPACE variable.
| *CYGWIN*) | ||
| wget https://github.com/AdoptOpenJDK/openjdk-releases/releases/download/jdk8u152-b04/OpenJDK8_x64_Win_jdk8u152-b04.zip | ||
| unzip OpenJDK8_x64_Win_jdk8u152-b04.zip | ||
| ;; |
There was a problem hiding this comment.
Hard coded binaries? Should be parameterized?
There was a problem hiding this comment.
This will be enhanced depending on how we would like to run the tests(e.g. nightly only run latest? developer run specific version? What is the available gitHub APIs...). Currently we'd like to enable the build first as it seems build on windows have more issues than on Linux.
There was a problem hiding this comment.
OK, as long as we have an Issue or a TODO somewhere :-)
get.sh
Outdated
| download_url=`curl https://api.github.com/repos/AdoptOpenJDK/openjdk-releases/releases/latest | jq -r '.assets[] | select(.browser_download_url | contains("x64_Linux_jdk")) | {url: .browser_download_url} | select (.url | contains("tar.gz")) | .[]'` | ||
| wget "${download_url}" | ||
| #wget https://github.com/AdoptOpenJDK/openjdk-releases/releases/download/jdk8u152-b01/OpenJDK8_x64_Linux_jdk8u152-b01.tar.gz | ||
| jar_file_url=$download_url |
get.sh
Outdated
| jar_file_name=${jar_file_url##*/} | ||
| tar -zxvf $jar_file_name | ||
| #tar -zxvf OpenJDK8_x64_Linux_jdk8u152-b01.tar.gz ;; | ||
| esac |
Signed-off-by: Sophia Guo <[email protected]>
|
Given that variables OPENJDK_TEST and JAVA_BIN are only needed for specific stages move them from global settings to withEnv blocks. This way we won't need environment variable WORKSPACE in environment section on windows platform, which is a bug and not know when/will it be fixed. PR updated. @karianna @smlambert please take another review. Thanks. |
Signed-off-by: Sophia Guo [email protected]