Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable tests excluded by issue 248 on jdk18 #3263

Merged
merged 1 commit into from
Jan 22, 2022

Conversation

gervaisj
Copy link
Contributor

Re-enabled tests excluded by adoptium/temurin-build#248. Partial fix of: #3214

This patch re-enables JDK 18 test excluded by adoptium/temurin-build#248.

Hotspot

grinder https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/3184/testReport/
grinder (mac) https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/3168/testReport/

jdk_lang

image
image
image

jdk_nio

image

jdk_tools (wrongly categorized as jdk_lang; mac only)

image

OpenJ9

grinder (mac) https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/3180/testReport/

jdk_lang

(java/lang/ClassLoader/nativeLibrary/NativeLibraryTest fails but executes. Same behavior for JDK11 on #3255)
image
image

jdk_tools (wrongly categorized as jdk_lang; mac only)

Cannot verify execution of vm/JniInvocationTest (for now) since jdk_tools is disabled on openj9.
playlist.xml:

		<testCaseName>jdk_tools</testCaseName>
		<disables>
			<disable>
				<comment>https://github.com/eclipse-openj9/openj9/issues/10757</comment>
				<impl>openj9</impl>
			</disable>

@gervaisj
Copy link
Contributor Author

@llxia eclipse-openj9/openj9#10757 seems to be preventing me from validating the change to openj9. Is there an alternative to force run the test?

@gervaisj
Copy link
Contributor Author

@smlambert Some details regarding the failed test on the first grinder run for which I had to check if the nightly build was at fault:

On grinder 3157 (xLinux), jdk18 failed a test that wasn't part of the ones I re-enabled. I tried to investigate if the nightly build had the issue, but no test pipeline had run on that particular build to verify.

On grinder 3170, I then tried to use a release build instead of the nightly. The script failed because there is no release of jdk18 yet (only early access). I had to look at some scripts and make the requests on my end, maybe we could improve the error reporting on that (if no release is available).

On grinder 3175, I tried the same nightly build as 3157 but this time on arm64Linux with master (no changes of mine). It passed. So it seemed it was not the build...

On grinder 3177, I tried the same nightly build again, but on xLinux (same as 3157) with master. Again it passed. So it seemed like my changes were causing the issue... (how?!)

On grinder 3184, I tried the same configuration as 3157 (xLinux, nightly build, with my changes) on the same machine and it passed.

Finally, on grinder 3186, I reran grinder on that machine again with ITERATION=5 to see if I could reproduce the issue. But all 5 iterations passed.

The machine in question is test-ibmcloud-rhel7-x64-1.

I don't think any further action is required (except maybe for the error reporting), but I thought I'd document the investigation here.

@llxia
Copy link
Contributor

llxia commented Jan 22, 2022

We can remove the exclusion of JniInvocationTest from the problem list for now (no need to validate). The JniInvocationTest will still be excluded by eclipse-openj9/openj9#10757, which is fine. We will evaluate JniInvocationTest once we get chance to work on eclipse-openj9/openj9#10757

Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gervaisj

Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smlambert smlambert merged commit 7545fad into adoptium:master Jan 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants