Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable tests excluded by issue 248 #3214

Closed
sophia-guo opened this issue Jan 12, 2022 · 6 comments · Fixed by #3271
Closed

Re-enable tests excluded by issue 248 #3214

sophia-guo opened this issue Jan 12, 2022 · 6 comments · Fixed by #3271

Comments

@sophia-guo
Copy link
Contributor

Re-enable tests excluded by issue 248

Issue 248 has been resolved, that is testImage is generated by jenkins build jobs. Also corresponding option -nativepath has also been added and updated gradually. Those tests should be re-enabled.

@sophia-guo
Copy link
Contributor Author

Related with #2368

@llxia
Copy link
Contributor

llxia commented Jan 13, 2022

Detail Steps:

For example https://github.com/adoptium/aqa-tests/blob/master/openjdk/excludes/ProblemList_openjdk18.txt#L51

java/lang/ClassLoader/nativeLibrary/NativeLibraryTest.java	https://github.com/adoptium/temurin-build/issues/248	generic-all
  • To reenable, we just need to remove the entry.
  • If have permission, please run Grinder to verify the result.
JDK_VERSION=18
JDK_IMPL=hotspot
BUILD_LIST=openjdk
TARGET=jdk_custom
CUSTOM_TARGET=java/lang/ClassLoader/nativeLibrary/NativeLibraryTest.java
  • If the test passes, reenable it. Otherwise, open a new issue accordingly and update ProblemList with the new issue URL.

@sophia-guo
Copy link
Contributor Author

Probably keep it as is for the retired openjdk. That is we will only re-enable for jdk11, jdk17+ ( native tests has been disabled for jdk8 ).

@tommytwm
Copy link
Contributor

I can take jdk 11 :)

@yinggzz
Copy link
Contributor

yinggzz commented Jan 21, 2022

I can do jdk 17

@gervaisj
Copy link
Contributor

I can do jdk 18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants