Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move problem lists #2428

Merged
merged 4 commits into from
Mar 31, 2021
Merged

Move problem lists #2428

merged 4 commits into from
Mar 31, 2021

Conversation

patkarns
Copy link
Contributor

@patkarns patkarns commented Mar 31, 2021

Fixes #2400

Copy link
Contributor

@sophia-guo sophia-guo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smlambert
Copy link
Contributor

Grinder for jdk_lang/hs/jdk11/x86_linux:
https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder_TKG/225

seems to have some trouble:

15:35:28  -w ""/home/jenkins/workspace/Grinder_TKG/openjdk-tests/TKG/../TKG/output_16172193276035/jdk_lang_1"/work" \
15:35:28  -r "/home/jenkins/workspace/Grinder_TKG/openjdk-tests/TKG/../../jvmtest/openjdk/report" \
15:35:28  -jdk:"/home/jenkins/workspace/Grinder_TKG/openjdkbinary/j2sdk-image" \
15:35:28  -exclude:"/home/jenkins/workspace/Grinder_TKG/openjdk-tests/TKG/../openjdk/openjdk-jdk/test/jdk/ProblemList.txt" \
15:35:28  -exclude:"/home/jenkins/workspace/Grinder_TKG/openjdk-tests/TKG/../../jvmtest/openjdk/excludes/ProblemList_openjdk11.txt" \
15:35:28  "/home/jenkins/workspace/Grinder_TKG/openjdk-tests/TKG/../openjdk/openjdk-jdk/test/jdk:jdk_lang"; \
15:35:28  if [ $? -eq 0 ] ; then echo ""; echo "jdk_lang_1""_PASSED"; echo ""; cd /home/jenkins/workspace/Grinder_TKG/openjdk-tests/TKG/..; rm -f -r "/home/jenkins/workspace/Grinder_TKG/openjdk-tests/TKG/../TKG/output_16172193276035/jdk_lang_1"; else echo ""; echo "jdk_lang_1""_FAILED"; echo ""; fi; } 2>&1 | tee -a "/home/jenkins/workspace/Grinder_TKG/openjdk-tests/TKG/../TKG/output_16172193276035/TestTargetResult";
15:35:28  Directory "/home/jenkins/workspace/Grinder_TKG/openjdk-tests/TKG/../TKG/output_16172193276035/jdk_lang_1/work" not found: creating
15:35:28  Directory "/home/jenkins/workspace/Grinder_TKG/openjdk-tests/TKG/../../jvmtest/openjdk/report" not found: creating
15:35:28  Error: Bad parameters specified: One of the files you specified was not found. The error reported was:
15:35:28  /home/jenkins/workspace/Grinder_TKG/jvmtest/openjdk/excludes/ProblemList_openjdk11.txt (No such file or directory)
15:35:28  
15:35:28  jdk_lang_1_FAILED

Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think it may be a case of us not copying the excludes folder over into the DEST folder where the tests are run... see https://github.com/AdoptOpenJDK/openjdk-tests/blob/master/openjdk/build.xml#L272

@sophia-guo
Copy link
Contributor

Correct @smlambert ! I forgot that.

@sophia-guo
Copy link
Contributor

Looks good now : https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder_TKG/226/console

Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @patkarns !

@smlambert smlambert merged commit d914649 into adoptium:master Mar 31, 2021
@karianna karianna added this to the March 2021 milestone Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collapse all openjdk problem list files into an excludes folder
4 participants