Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapse all openjdk problem list files into an excludes folder #2400

Closed
10 tasks
smlambert opened this issue Mar 20, 2021 · 0 comments · Fixed by #2428
Closed
10 tasks

Collapse all openjdk problem list files into an excludes folder #2400

smlambert opened this issue Mar 20, 2021 · 0 comments · Fixed by #2428

Comments

@smlambert
Copy link
Contributor

smlambert commented Mar 20, 2021

👾 Description of the issue

This is 'tidy-ness' item. We currently have all problem lists for all versions and vmImpls directly in the openjdk directory of this repo. It makes that directory quite cluttered and will only get worse.

This enhancement issue proposes to move all the problem list files into a new folder openjdk/excludes. If we do move them there, we will need to update the PROBLEM_LIST_FILE variable in openjdk.mk to the new location. See various ways it can be set, starting at openjdk.mk/L137.

📋 Step by Step

To solve this issue and contribute a fix you should check the following step-by-step list. A more detailed documentation of the workflow can be found here.

  • Claim this issue: Comment below.
  • Fork the repository in github by simply clicking the 'fork' button.
  • Check out the forked repository
  • Create a feature branch for the issue. We do not have any naming definition for branches.
  • Commit your changes.
  • Start a Pull Request.
  • Done 👍 Ask in comments for a review :)
  • If the reviewer find some missing pieces or a problem they will start a discussion with you and describe the next steps how the problem can be solved.
  • You did it 🎉 We will merge the fix in the master branch.
  • Thanks, thanks, thanks for being part of this project as an open source contributor ❤️

🤔❓ Questions

If you have any questions just ask us directly in this issue by adding a comment. You can join our community chat at Slack. Next to this you can find a general manual about open source contributions here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants