Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excluding openj9 specific tests and zos specific tests for jdk11 and later releases #2423

Merged
merged 28 commits into from
Apr 28, 2021
Merged

Excluding openj9 specific tests and zos specific tests for jdk11 and later releases #2423

merged 28 commits into from
Apr 28, 2021

Conversation

psoujany
Copy link
Contributor

Excuding openj9 specific tests and zos specific tests for jdk11 and later releases.

Openj9 exclusions:
jdk_management
java/lang/management/ManagementFactory/ValidateOpenTypes.java
java/lang/management/MemoryMXBean/MemoryManagement.java
java/lang/management/ManagementFactory/ProxyTypeMapping.java
java/lang/management/MemoryMXBean/CollectionUsageThreshold.java
java/lang/management/MemoryMXBean/LowMemoryTest2.sh
java/lang/management/GarbageCollectorMXBean/GcInfoCompositeType.java
java/lang/management/CompositeData/MemoryUsageCompositeData.java
javax/management/remote/mandatory/connection/DefaultAgentFilterTest.java
sun/management/jmxremote/bootstrap/LocalManagementTest.java
sun/management/jmxremote/startstop/JMXStartStopTest.java
sun/management/jmxremote/startstop/JMXStatusPerfCountersTest.java
sun/management/jmxremote/startstop/JMXStatusTest.java

z/OS specific:
jdk_nio
java/nio/channels/Selector/OutOfBand.java
java/nio/channels/FileChannel/directio/ReadDirect.java
java/nio/channels/FileChannel/directio/PreadDirect.java
java/nio/channels/FileChannel/directio/PwriteDirect.java
java/nio/channels/FileChannel/TempDirectBuffersReclamation.java

Note :- Openj9 specific exclusions are applicable for jdk11 and later versions whereas z/OS specific exclusions are applicable only for jdk11.

@karianna karianna added the bug label Mar 31, 2021
@karianna karianna changed the title Excuding openj9 specific tests and zos specific tests for jdk11 and later releases Excluding openj9 specific tests and zos specific tests for jdk11 and later releases Mar 31, 2021
@karianna karianna added this to the March 2021 milestone Mar 31, 2021
@smlambert smlambert requested review from llxia and Mesbah-Alam April 1, 2021 01:10
@llxia
Copy link
Contributor

llxia commented Apr 6, 2021

For permanent excludes, please use the correct issue number. i.e., #1297

For temporary excludes, please open the issue with more details.

#2422 does not have enough information as to failure defails and why the test should be excluded (product defect, infra issue, or test not applicable, etc)

If there is an internal issue opened for this, please put it in the description (with a format like backlog/issues/494) , so we can trace it back if needed.

psoujany and others added 20 commits April 7, 2021 11:38
Add instructions for running locally
Fix spelling
* Exclude failing extended.jck tests

Signed-off-by: [email protected] <[email protected]>

* Exclude failing extended.jck tests

Signed-off-by: [email protected] <[email protected]>
Similar to what is done for ACTUAL_TEST_JOB_NAME,
use and reset the ACTUAL_JCK_GIT_REPO every loop in
order to hit the condition everytime. Otherwise
JCK_GIT_REPO would be set on the first loop for the
duration of the build.

Signed-off-by: Adam Brousseau <[email protected]>
* Moved openjdk problem lists into excludes folder

* Edited path to ProblemList files
* remove PushOrPRtestbuild.yml

* Add JDK_NATIVE_OPTIONS to all test targets

Signed-off-by: yanshan24 <[email protected]>

* remove $(JDK_NATIVE_OPTIONS) and add $(JVM_NATIVE_OPTIONS) for hostpot test targets; modify jdk_build and jdk_jfc_demo test cases

Signed-off-by: yanshan24 <[email protected]>

* remove $(JVM_NATIVE_OPTIONS) from jdk_custom

Signed-off-by: Yanshan Wan <[email protected]>
)

On JDK8 with Hotspot, s390 has no JIT. This results in a number of
tests running for over an hour, eventually causing an
extended.openjdk test run on Jenkins to be aborted due to the usual
10hr timeout.

While it seems likely we will not be running extended.openjdk on s390
(for JDK8 on Hotspot, anyway) for much longer, I'm excluding these
tests for now so that the test bucket is viable, should we choose to
run it again in the future.

Signed-off-by: Adam Farley <[email protected]>
vanichitkara and others added 5 commits April 7, 2021 12:13
* Create README.md
* Create test.properties
* Delete Dockerfile

* Create README.md

* Create test.properties
* Style parameters in testJobTemplate
@psoujany
Copy link
Contributor Author

psoujany commented Apr 7, 2021

For permanent excludes, please use the correct issue number. i.e., #1297

For temporary excludes, please open the issue with more details.

#2422 does not have enough information as to failure defails and why the test should be excluded (product defect, infra issue, or test not applicable, etc)

If there is an internal issue opened for this, please put it in the description (with a format like backlog/issues/494) , so we can trace it back if needed.

Updated #2422 with individual open issues. Please review the changes. Thank you.

@@ -201,6 +213,12 @@ java/nio/channels/DatagramChannel/Promiscuous.java https://github.com/AdoptOpenJ
java/nio/channels/SocketChannel/AdaptSocket.java https://github.com/eclipse/openj9/issues/4317 macosx-all
java/nio/file/Files/CopyAndMove.java https://github.com/AdoptOpenJDK/openjdk-tests/issues/795 macosx-all
jdk/nio/zipfs/ZipFSTester.java https://github.com/eclipse/openj9/issues/4679 linux-x64,macosx-all
java/nio/channels/Selector/OutOfBand.java https://github.com/AdoptOpenJDK/openjdk-tests/issues/2422 z/OS-s390x
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to your comment in #2422, You are excluding java/nio/channels/Selector/OutOfBand.java temporarily due to openj9-openjdk-jdk11-zos/issues/575. So, The PR for the exclusion should have openj9-openjdk-jdk11-zos/issues/575 as the cause of this temporary exclusion, not #2422. I believe #2422 is just an issue you created for triage, it should not be used as a reason for an exclusion.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Mesbah-Alam - I think in a previous PR from @psoujany I had requested that we ideally reference open issues for exclusions (so that when we automate the checking of them, the automation script can access them). Though it is fine to reference the internal issue in the placeholder issue. (I don't like that we have duplicate issue, but I do not see a way around it, and I will hope that the temporary placeholder issues are not long-lived).

Copy link
Contributor

@Mesbah-Alam Mesbah-Alam Apr 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShelleyLambert Hi Shelley, oh.. I wasn't aware of that automation :) .. In that case I am fine with using the open issue in the exclude file! @psoujany , please Ignore my comment about using openj9-openjdk-jdk11-zos/issues/575!

Copy link
Contributor

@smlambert smlambert Apr 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mesbah-Alam - Its upcoming automation (related: #1853 and #2368), but thought to enforce the use of full and openly accessible URLs so that when we do finish the automation, we do not have to update as many playlists and problemlists.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShelleyLambert - makes sense Shelley!

@smlambert
Copy link
Contributor

I do not know where this sits, or if its ready for merge (and not a way to verify on zos). Relying on @Mesbah-Alam and @llxia for review. As its exclusions, it will be exempt from the code freeze that will be in place until release next week completes.

@karianna karianna modified the milestones: March 2021, April 2021 Apr 19, 2021
@pushkarnk
Copy link

I guess this is ready for merge. Can we merge it pease?

@mamatha-jv
Copy link
Contributor

@llxia
Can you please merge this?

@llxia
Copy link
Contributor

llxia commented Apr 21, 2021

Not sure if z/OS-s390x works. Did we test it in Grinder?

@psoujany
Copy link
Contributor Author

Not sure if z/OS-s390x works. Did we test it in Grinder?

Yes z/OS-s390x works, here's the Grinder hyc-runtimes-team-svt-jenkins.swg-devops.com/Test_grinder/job/Grinder/1207

@llxia
Copy link
Contributor

llxia commented Apr 22, 2021

Thanks @psoujany

@mamatha-jv
Copy link
Contributor

@Mesbah-Alam
Can you please review this issue?

Copy link
Contributor

@Mesbah-Alam Mesbah-Alam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mamatha-jv
Copy link
Contributor

@Mesbah-Alam Thank you.
@llxia Can you please merge this now?

@llxia
Copy link
Contributor

llxia commented Apr 28, 2021

FYI @pshipton @JasonFengJ9

@llxia llxia merged commit 1f1db41 into adoptium:master Apr 28, 2021
@mamatha-jv
Copy link
Contributor

@llxia Thank you very much!

@psoujany psoujany deleted the zosjtreg-exclusions branch May 25, 2021 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.