Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add adopters page #1644

Merged
merged 31 commits into from
Aug 29, 2023
Merged

add adopters page #1644

merged 31 commits into from
Aug 29, 2023

Conversation

gdams
Copy link
Member

@gdams gdams commented Mar 29, 2023

Description of change

Please do not merge until this PR is taken out of draft

NOTE: MongoDB has to get one more approval (hence why I commented their logo out)

Checklist

  • npm test passes
  • documentation is changed or added (if applicable)
  • permission has been obtained to add new logo (if applicable)
  • contribution guidelines followed here

@netlify
Copy link

netlify bot commented Mar 29, 2023

Deploy Preview for eclipsefdn-adoptium ready!

Name Link
🔨 Latest commit 9200ec1
🔍 Latest deploy log https://app.netlify.com/sites/eclipsefdn-adoptium/deploys/64e4ba5065f8380008fb0661
😎 Deploy Preview https://deploy-preview-1644--eclipsefdn-adoptium.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tellison
Copy link
Contributor

The homepage carousel:

  • Not a fan of the "flying" rotation rather than a constant ticker-tape version, but that's just my taste.
  • While I know it is common practice, I think it is questionable that we should modify companies' logos to grayscale without them being explicitly provided to use that way, or such modifications being advised in our usage agreement.
  • Size and layout look good.

The adopters page:

  • Is the plan to make this a page with testimonials, or a simple table of logos?

@gdams
Copy link
Member Author

gdams commented Mar 29, 2023

Not a fan of the "flying" rotation rather than a constant ticker-tape version, but that's just my taste.

Yeah there's not an easy way to modify this tbh.

While I know it is common practice, I think it is questionable that we should modify companies' logos to grayscale without them being explicitly provided to use that way, or such modifications being advised in our usage agreement.

Let's make this part of the usage agreement, also noting that we're vetting companies to go on our home page so we can likely manually perform this check if needed.

Is the plan to make this a page with testimonials, or a simple table of logos?

To start with this will be a table of logos, although I do envisage this having a testimonials slider at the top as per the AdoptOpenJDK testimonials page. Let's get some testimonials and then I'll work on adding support for this.

@CarmenDelgadoEclipse
Copy link

CarmenDelgadoEclipse commented Apr 25, 2023

Hello, I asked the EF marketing team to review the proposal, and they are happy; the only comment will be if we can remove "page" from the title, only "Eclipse Temurin™ Adopters" and other one related to the submission process, added to the Github Issues.

How can I get my logo displayed comments:

  1. Missing the logo formats information, just like:https://ecdtools.eclipse.org/adopters/get-listed/

Logo Formats

File should be transparent SVG files and compressed for the web.
PNG files are accepted as an alternative.

The background color needs to be transparent so that it works on colored backgrounds.

The white version is required for some contexts, and that version needs to be transparent as well as it will not always appear on a white background. See here for an example.

For any questions or to provide feedback, please contact us.

  1. under "options 1 - Open and Issue", last step should the number "3" :)

  2. also, could you expand the definition of an adopters?

Who is Considered an Adopter?
Adopters are organizations and, or companies that use Eclipse Temurin in production. These organizations may be using this runtime as the basis for commercial products, for non-commercial tools, or for internal tools.

@CarmenDelgadoEclipse
Copy link

Other feedback, not sure if this one should go here or in parent issue, carrousel description should mention "Eclipse Temurin adopter" or similar :)

@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Merging #1644 (9200ec1) into main (768a4ff) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1644      +/-   ##
==========================================
+ Coverage   99.17%   99.18%   +0.01%     
==========================================
  Files          85       86       +1     
  Lines        6270     6396     +126     
  Branches      535      538       +3     
==========================================
+ Hits         6218     6344     +126     
  Misses         52       52              
Files Changed Coverage Δ
src/components/MembersGrid/index.tsx 100.00% <100.00%> (ø)
src/components/NavBar/index.tsx 97.56% <100.00%> (+0.01%) ⬆️
src/pages/adopters.tsx 100.00% <100.00%> (ø)
src/pages/members.tsx 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@gdams gdams changed the title add adopters page and brand carousel to homepage add adopters page Aug 15, 2023
@gdams gdams force-pushed the carousel branch 2 times, most recently from b414c61 to 703082d Compare August 15, 2023 14:38
@gdams gdams marked this pull request as ready for review August 29, 2023 10:49
@gdams gdams merged commit e5fd32a into adoptium:main Aug 29, 2023
11 checks passed
@gdams gdams deleted the carousel branch August 29, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create an 'adopters' page
3 participants