-
-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add adopters page #1644
add adopters page #1644
Conversation
✅ Deploy Preview for eclipsefdn-adoptium ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
The homepage carousel:
The adopters page:
|
Yeah there's not an easy way to modify this tbh.
Let's make this part of the usage agreement, also noting that we're vetting companies to go on our home page so we can likely manually perform this check if needed.
To start with this will be a table of logos, although I do envisage this having a testimonials slider at the top as per the AdoptOpenJDK testimonials page. Let's get some testimonials and then I'll work on adding support for this. |
Hello, I asked the EF marketing team to review the proposal, and they are happy; the only comment will be if we can remove "page" from the title, only "Eclipse Temurin™ Adopters" and other one related to the submission process, added to the Github Issues. How can I get my logo displayed comments:
|
Other feedback, not sure if this one should go here or in parent issue, carrousel description should mention "Eclipse Temurin adopter" or similar :) |
Codecov Report
@@ Coverage Diff @@
## main #1644 +/- ##
==========================================
+ Coverage 99.17% 99.18% +0.01%
==========================================
Files 85 86 +1
Lines 6270 6396 +126
Branches 535 538 +3
==========================================
+ Hits 6218 6344 +126
Misses 52 52
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
b414c61
to
703082d
Compare
Description of change
Please do not merge until this PR is taken out of draft
NOTE: MongoDB has to get one more approval (hence why I commented their logo out)
Checklist
npm test
passes