Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug]: don't mutate options to validator #119

Merged
merged 4 commits into from
Feb 9, 2022

Conversation

betocantu93
Copy link
Contributor

Redo of #85 , avoid mutations for options.

@betocantu93 betocantu93 mentioned this pull request Feb 8, 2022
Copy link
Collaborator

@snewcomer snewcomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Phenomenal tests!

@snewcomer snewcomer changed the title don't mutate [bug]: don't mutate options Feb 9, 2022
@snewcomer snewcomer changed the title [bug]: don't mutate options [bug]: don't mutate options to validator Feb 9, 2022
@snewcomer snewcomer merged commit 90a5e3d into adopted-ember-addons:master Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants