Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed template and replaced with hasBlock. #118

Conversation

benedikt-buchert
Copy link

Because template is deprecated in Ember 1.13

@miguelcobain
Copy link
Collaborator

  1. There are other places where we use template, not just on paper-button. When we change it, we must change it everywhere.
  2. This would fail for people using Ember 1.12, right?
  3. I think a good approach would be to have a computed property called hasBlock on a separate mixin that would check for both hasBlock (super) and template. When Ember 1.13 hits release channel, we can get rid of that mixin.

@benedikt-buchert
Copy link
Author

  1. Maybe have not seen them. Gotta check.
  2. Yes I think it would fail.
  3. Hasn't 1.13 hit the release channel? You are right though backwards compatibility is always good!

@benedikt-buchert
Copy link
Author

Another possibility is to make different forks for different versions of Ember. The downside is that you have to support different versions and that older versions of ember probably won't benefit from all the new stuff that is coming unless there is pull requests for those... But also you would not have that much old stuff stuck in the code. #100

@miguelcobain
Copy link
Collaborator

@benedikt-d

Briefing:

So, can you merge these changes with latest master?

@benedikt-buchert benedikt-buchert deleted the button-hasBlock branch July 10, 2015 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants