Glimmer support / hasBlock support

[SirZach]

After upgrading to ember/canary to get the glimmer engine, paper-buttons no longer show up in the app. I'm not entirely sure why this is breaking.

[SirZach]

If you could point me in the right direction I could take a crack at getting a PR going

[miguelcobain]

@SirZach, ember-try tests against ember canary. Looks like the tests are passing in ember canary.

What is exactly the problem? What don't the buttons show up?
Please try with the latest 0.1.0 version.

[SirZach]

I'll try with 0.1.0 tonight. The text in the buttons were not showing up.

On Wed, May 27, 2015, 6:23 AM Miguel Andrade [email protected]
wrote:

@SirZach https://github.com/SirZach, ember-try tests against ember
canary. Looks like the tests are passing in ember canary.

What is exactly the problem? What don't the buttons show up?
Please try with the latest 0.1.0 version.

—
Reply to this email directly or view it on GitHub
#86 (comment)
.

[miguelcobain]

How did it go?

[SirZach]

I'm seeing that if I use the buttons as block components then the text on the button doesn't show up. If I switch it over to a non-block component and set the text to the label attribute, it'll show up.

[miguelcobain]

Nice.

A failing test would be awesome.

[miguelcobain]

Looks like the way to go now is using hasBlock: http://emberjs.com/api/classes/Ember.Component.html#property_hasBlock

[SirZach]

I'll take a crack at spinning up a PR although not sure when you can merge it since I'm not sure when you want to start supporting glimmer...

[miguelcobain]

Ideally we should support the same versions that ember-try tests, and that includes Glimmer.
There are things we can do to support both pre and post glimmer.

[SirZach]

So I've been playing around with some tests and whatnot and have found that if I use ember-1.13 or later then using hasBlock is the way to go, otherwise, we need to use template. I can write a computed property in the base component to check for hasBlock first and then fall back to template if that makes sense to you.

[SirZach]

currently dealing with a bug where the actual implementation for hasBlock has disappeared. tracking progress at emberjs/ember.js#11301. until that's fixed my PR will have to be on hold

[SirZach]

When emberjs/ember.js#11313 is merged in, we'll be able to continue to check for {{#if template}} until you don't want to support pre-Glimmer and then you can make the change to hasBlock.

[miguelcobain]

Bingo. 👍

[benedikt-buchert]

#118

[miguelcobain]

Closed via #113.