-
-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only rebuild on changes to (sass|scss|css) files #220
Only rebuild on changes to (sass|scss|css) files #220
Conversation
1c7c699
to
4acf427
Compare
Gave this a quick try in our production ember apps, and seems to work fine. Please let me know if you see any downsides to this approach, and if there are any other changes to be made here (wasn't sure if I needed to add this to the CHANGELOG section in the readme) |
Hi team, is there anything I can do to help get this reviewed and merged? Right now I'm waiting 8s more than I need to when I change a template because our styles include foundation and broccoli thinks it needs to recompile all of foundation just because I added a paragraph to some template. |
Please review and merge it. Thanks! |
@rwjblue @gabrielcsapo sorry for the direct ping, figured you might be able to help here since you both are the only committers in this repo after ownership was transferred over. Please let me know if I can help in any way to move this forward. |
@rohitpaulk might be worth pinging folks on the Discord channel for adopted addons as well to see about adding additional committers here, Rob Jackson has been swamped |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Should be out as v11 |
@knownasilya thank you! |
@rohitpaulk thank you!!! |
Thank you!
Alex Kanunnikov ***@***.***> ezt írta (időpont: 2022. ápr.
26., K, 7:58):
… @rohitpaulk <https://github.com/rohitpaulk> thank you!!!
—
Reply to this email directly, view it on GitHub
<#220 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABNZSWEDXUNBZOJSZR5LELVG6AZPANCNFSM5EIOMCZQ>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Fixes #214.
Related:
extension
for filtering, doesn't account for the fact that SCSS files can import regular.css
files too)