Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only rebuild on changes to (sass|scss|css) files #220

Conversation

rohitpaulk
Copy link
Contributor

Fixes #214.

Related:

@rohitpaulk
Copy link
Contributor Author

Gave this a quick try in our production ember apps, and seems to work fine.

Please let me know if you see any downsides to this approach, and if there are any other changes to be made here (wasn't sure if I needed to add this to the CHANGELOG section in the readme)

@krainboltgreene
Copy link

krainboltgreene commented Nov 12, 2021

Hi team, is there anything I can do to help get this reviewed and merged? Right now I'm waiting 8s more than I need to when I change a template because our styles include foundation and broccoli thinks it needs to recompile all of foundation just because I added a paragraph to some template.

neomobil
neomobil approved these changes Apr 21, 2022
@neomobil
Copy link

Please review and merge it. Thanks!

@rohitpaulk
Copy link
Contributor Author

@rwjblue @gabrielcsapo sorry for the direct ping, figured you might be able to help here since you both are the only committers in this repo after ownership was transferred over. Please let me know if I can help in any way to move this forward.

@acorncom
Copy link

@rohitpaulk might be worth pinging folks on the Discord channel for adopted addons as well to see about adding additional committers here, Rob Jackson has been swamped

Copy link

@NullVoxPopuli NullVoxPopuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@knownasilya knownasilya merged commit 4d2c796 into adopted-ember-addons:master Apr 25, 2022
@rohitpaulk rohitpaulk deleted the only-rebuild-for-scss-changes branch April 25, 2022 19:02
@knownasilya
Copy link
Collaborator

Should be out as v11

@lifeart
Copy link

lifeart commented Apr 26, 2022

@knownasilya thank you!

@lifeart
Copy link

lifeart commented Apr 26, 2022

@rohitpaulk thank you!!!

@neomobil
Copy link

neomobil commented Oct 11, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] sass funnel being rebuilt on files that are not (.scss|.css|.sass)
8 participants