Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR 504 - Updates to make changes additive #513

Merged
merged 2 commits into from
Sep 27, 2018
Merged

PR 504 - Updates to make changes additive #513

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ad1f44
updates on PR 504 to make changes additive only
kstreeter Sep 25, 2018
04ac47a
Merge branch 'master' into pr-504-fix
kstreeter Sep 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion schemas/context/experienceevent.example.1.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@
"xdm:marketing": {
"xdm:trackingCode": "marketingcampaign111"
},
"xdm:profileStitching": [
"xdm:profileStitch": [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could also call this profileMerge also as another option, but this is fine. Either way it's confusing with the other field.

{
"xdm:profileStitchID": {
"@id": "https://data.adobe.io/entities/profileStitchIdentity/1",
Expand Down
10 changes: 8 additions & 2 deletions schemas/context/experienceevent.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,14 +111,20 @@
"$ref": "https://ns.adobe.com/xdm/context/media",
"description": "The media activity information related to the experience event"
},
"xdm:profileStitching" : {
"title": "Profile Stitching",
"xdm:profileStitch" : {
"title": "Profile Stitch",
"description": "Details about the ids that were joined by profile stitching.",
"type" : "array",
"items" : {
"$ref": "https://ns.adobe.com/xdm/context/profileStitch"
}
},
"xdm:profileStitching" : {
"meta:status": "deprecated",
"title": "Profile Stitching",
"description": "Details about the ids that were joined by profile stitching. Deprecated, use `xdm:profileStitch`",
"$ref": "https://ns.adobe.com/xdm/context/profileStitch"
},
"xdm:segmentMemberships": {
"title": "Segment Memberships",
"description": "The segments associated with this experience event",
Expand Down
6 changes: 6 additions & 0 deletions schemas/context/profilestitch.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,12 @@
},
"minItems": 1,
"description": "Array of Identities. Condensed, normalized encapsulation of all end user identifiers."
},
"xdm:endUserIDs": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my big worry here is that when we have IdentityMap, we'll have three fields for representing identity here. I get that we'll deprecate the old ones, but just want to document it here on the review.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

understood @harleensahni, we will plan on cleaning up some of these early deprecations before we call 1.0. They are just helping with current limitations in the tooling.

"meta:status": "deprecated",
"title": "End User IDs",
"$ref": "https://ns.adobe.com/xdm/context/enduserids",
"description": "Condensed, normalized encapsulation of all end user identifiers. Deprecated"
}
}
}
Expand Down
11 changes: 11 additions & 0 deletions schemas/context/segmentmembershipitem.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,17 @@
"properties": {
"xdm:profileStitchID": {
"$ref": "https://ns.adobe.com/xdm/context/profileStitchIdentity"
},
"xdm:identities": {
"meta:status": "deprecated",
"title": "All User Identities",
"type": "array",
"items": {
"$ref": "https://ns.adobe.com/xdm/context/identity"
},
"minItems": 1,
"description":
"Array of Identities. Condensed, normalized encapsulation of all end user identifiers. Deprecated"
}
}
}
Expand Down