PR 504 - Updates to make changes additive #513
Conversation
| @@ -115,7 +115,7 @@ | |||
| "xdm:marketing": { | |||
| "xdm:trackingCode": "marketingcampaign111" | |||
| }, | |||
| "xdm:profileStitching": [ | |||
| "xdm:profileStitch": [ | |||
There was a problem hiding this comment.
we could also call this profileMerge also as another option, but this is fine. Either way it's confusing with the other field.
| @@ -31,6 +31,12 @@ | |||
| }, | |||
| "minItems": 1, | |||
| "description": "Array of Identities. Condensed, normalized encapsulation of all end user identifiers." | |||
| }, | |||
| "xdm:endUserIDs": { | |||
There was a problem hiding this comment.
my big worry here is that when we have IdentityMap, we'll have three fields for representing identity here. I get that we'll deprecate the old ones, but just want to document it here on the review.
There was a problem hiding this comment.
understood @harleensahni, we will plan on cleaning up some of these early deprecations before we call 1.0. They are just helping with current limitations in the tooling.
|
@cdegroot-adobe, that's what this PR is: it makes the change non-breaking by keeping the original definitions and marking them as deprecated. |
PR #504 was merged with several breaking changes. This PR updates these changes to make them additive only.