fix: defer loading of head.html to allow inclusion of request cookie #2275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR will trigger a patch release when merged. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2275 +/- ##
==========================================
+ Coverage 93.39% 93.43% +0.03%
==========================================
Files 26 26
Lines 3574 3594 +20
Branches 1 1
==========================================
+ Hits 3338 3358 +20
Misses 236 236 ☔ View full report in Codecov by Sentry. |
dominique-pfister
approved these changes
Nov 15, 2023
|
🎉 This PR is included in version 16.0.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix changes the way how the remote head.html is loaded (the remote head.html version is needed to properly calculating how the local head.html needs to be injected into the html page).
instead of fetching the head.html during startup, it is deferred until the proxy server actually needs it. this is after the browser sent eventual request cookie. this allows that the remote head.html can be fetched also for authenticated sites.
fixes #2274