Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

head.html is not loaded from localhost when site authentication is configured. #2274

Closed
DriftingSands opened this issue Nov 14, 2023 · 1 comment · Fixed by #2275
Closed

head.html is not loaded from localhost when site authentication is configured. #2274

DriftingSands opened this issue Nov 14, 2023 · 1 comment · Fixed by #2275
Labels
bug Something isn't working released

Comments

@DriftingSands
Copy link

Description
head.html is not loaded from localhost when site authentication is configured.
If you want to test changes to the head.html file, you need to disable / empty the config google sheet, before the head.html can be loaded from localhost.

To Reproduce
Steps to reproduce the behavior:

  1. Set up site authentication following the docs
  2. Start up dev on localhost, open in brower and login
  3. change head.html locally
  4. changes to head.html file will not appear on localhost
  5. console error will show that head.html could not be loaded and is taken from the main.live version.

Expected behavior
head.html should be loaded form localhost after logging in

Screenshots
image

Version:
15.0.1

Additional context
I have an API key setup for my project. It's possible that this has something to do with it, but never noticed if this was occurring before I had that setup
@DriftingSands DriftingSands added the bug Something isn't working label Nov 14, 2023
tripodsan added a commit that referenced this issue Nov 15, 2023
@tripodsan
fix: defer loading of head.html to allow inclusion of request cookie
926aff5 
fixes #2274
@tripodsan tripodsan mentioned this issue Nov 15, 2023
Merged
tripodsan added a commit that referenced this issue Nov 16, 2023
@tripodsan
fix: defer loading of head.html to allow inclusion of request cookie
1a8d2ac 
fixes #2274
tripodsan pushed a commit that referenced this issue Nov 16, 2023
@semantic-release-bot
chore(release): 16.0.7 [skip ci]
23e3f40 
## [16.0.7](v16.0.6...v16.0.7) (2023-11-16)

### Bug Fixes

* defer loading of head.html to allow inclusion of request cookie  ([1a8d2ac](1a8d2ac)), closes [#2274](#2274)
@tripodsan
Copy link
Contributor

🎉 This issue has been resolved in version 16.0.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: defer loading of head.html to allow inclusion of request cookie adobe/helix-cli
2 participants
@tripodsan @DriftingSands