-
Notifications
You must be signed in to change notification settings - Fork 27
Technical Minutes 2021 07 29
- In attendance: Arjan L, Andrew C, Sven S, Thomas D
The group worked through a number of issues at the last meeting. There are some issues we have not quite closed but have reached decisions on how we would be handling them. Pull requests have been created for some. There are still a few where we did not reach a decision.
1. Quick changes: improvements to death, treatments, departure, milking (#227)
Andrew C has created one large pull request addressing a number of tickets discussed last time.
- Additional death reasons and death methods, resolves #224
- Added Unknown departure reason, resolves #206
- Added Number of treatments and treatment interval to courses, resolves #219
- Added temperature to milking characteristics (text description), x,y,z position to quarter, resolves #170.
A correction was made to a typo in Nutrition in ReasonType.
There was some discussion on who could approve the pull request. Andrew C will arrange write access for Andreas S. Andrew C will make a note in the Wiki on who has write access. Assigned to Arjan L to review
2. Add "PregnantMultipleFoetus" in the icarAnimalReproductionStatusType (#223)
There was some discussion about whether there was any value in trying to represent the number of foetuses in icarAnimalCoreResource's reproductionStatus. We have not yet added the PregnantMultipleFoetus value to the enumeration in the icarAnimalReproductionStatusType. Assigned to Andrew C
3. Add "icarQuarterId" in the TreamentEventresources (#221)
Erwin S has done a pull request but it needs to be tidied up. Assigned to Erwin S
4. Milking Statistics (#218)
Andreas S has addressed Milking Statistics in pull request #225 but which is not linked to #218. The pull request has been approved and so this can be marked as closed.
5. New values for production purposes (#215)
Discussion has gone around in circles for two meetings now and so we are going to wait until Anton is back. To discuss at a future date when Anton H is also present.
6. Nullable declaration is not working correctly for reference types (#214)
We agreed this will continue to wait until Anton is back. To discuss at a future date when Anton H is also present.
7. Remove DoNotBreed from an animal (#213)
We agreed to create a new ticket, marked as a breaking change, to rename icarReproDoNotBreedEventResource to something else. Assigned to Arjan L
8. Add 2 types to the icarReproParturitionResource (#191)
The requirement is to record other things about the calving or lambing of an animal whose parturition is being recorded. Things which are information about the progeny not the animal. For instance, SurvivalStatus is about the progeny but it reflects back on the mother as well. You could record SurvivalStatus and BirthWeight on an animal record for the progeny. But we might not want to do this, for example if the animal is born dead. We discussed at the last meeting an alternative that we could create a new structure which tells us about the progeny of a partutrition and use that instead. The progeny resource could be extended to include other things that are not used widely. We solve this ticket by creating the progeny resource in this release and deprecate the existing progeny array. We create a new ticket marked as breaking to remove the existing progeny array in release 2.0.
9. Semantics for POST Method (#154)
The handling of batch posts was discussed at the last two meetings. There is a Pull Request to review which has many comments. We are keen to include it in release 1.2.
An array of batch results is returned. If it is not successful, we will get back an array of messages which have severity of whether they are errors or warnings. Potentially there may be multiple warnings for each resource.
We have taken the example URL scheme and broken it up by tag to give smaller URL scheme examples.
Once this case is done, Erwin and Andrew will create equivalent URL schemes for the other areas. Assigned to Arjan L to review
10. Added positions in the treatment and diagnosis resource (#226)
Erwin's pull request has already been reviewed. Andrew could merge it and edit the file to change the case in the enumeration. Andrew will do a new pull request. Assigned to Andrew C
Observation that release 1.2 has taken quite some time to be finalised. The question for next release was whether we want to push out what is ready or are we fine with having it less frequent. We could just release each pull request that is reviewed and merged. Partners could choose to only support specific versions. We could automate code gen testing. We could have a closing agenda point of whether we want to make a release.
Next meeting scheduled for 12 August 2021 at 8:15am CET