Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing codes for MilkCharacteristicsType #170

Closed
dirbSEGES opened this issue Oct 21, 2020 · 5 comments
Closed

Missing codes for MilkCharacteristicsType #170

dirbSEGES opened this issue Oct 21, 2020 · 5 comments

Comments

@dirbSEGES
Copy link

Hi,

From Seges side we are missing these code in MilkCharacteristics:

Udderpositions used for each QuarterMilkingType used to calculate breedingvalues for udder:
"ZPOSITION"
"XPOSITION"
"YPOSITION"

And also these codes are missing:

"TEMPERATURE" (milk temperature in °C or °F)
"YIELDDAY" (Average yield last 24 hour i KGM)
"AVGYIELDWEEK" (Average yield last 7 days)

BR

@erwinspeybroeck
Copy link
Collaborator

It is always possible to add certain attributes to a response.
We have with Lely agreed upon adding the teat coordinates in an extended milking visit message. We could add this into the standard.

Temperature could be an extra characteristic

averages to my opinion should not be added in a milking visit event, but migth be part of another event

@dirbSEGES
Copy link
Author

It would be great if the coordinates and temperature are added to the standards.

I won't disagree with you about the averages.

@erwinspeybroeck
Copy link
Collaborator

Example of how the positions are in the response right now - would that be ok?

     "icarQuarterId": "LR",
        "xposition": 64,
        "yposition": 972,
        "zposition": 547,
        "quarterMilkingDuration": {
          "unitCode": "SEC",
          "value": 243
        },
        "quarterMilkingWeight": {
          "unitCode": "KGM",
          "value": 3.9
        },

@dirbSEGES
Copy link
Author

Yes, it is okay.

@cookeac
Copy link
Collaborator

cookeac commented Jul 15, 2021

Agreed that Temperature should be added. We can add X, Y, Z positions as nullable because not all providers may wish to provide these. Average yields will be a separate API.

cookeac added a commit to cookeac/ICAR that referenced this issue Jul 26, 2021
* Added "Unknown" to Departure Reason. Resolves adewg#206.
* Added x/y/z positions to QuarterMilking, and TEMPERATURE to milk characteristics. Resolves adewg#170.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants