Quick changes: improvements to death, treatments, departure, milking #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
cookeac
commented
Jul 26, 2021
cookeac
commented
- Additional death reasons and death methods, resolves Extension to IcarMovementDeathEventResource #224
- Added Unknown departure reason, resolves Request to add "Unknown" to icarDepartureReasonType enumeration #206
- Added Number of treatments and treatment interval to courses, resolves TreamentProgramRessource? #219
- Added temperature to milking characteristics (text description), x,y,z position to quarter, resolves Missing codes for MilkCharacteristicsType #170
URL scheme for ADE-1.x-health with POST and batch POST methods.
Adjustments to the enumerated values for death event reasons and methods (kinds). Resolves adewg#224.
Added numberOfTreatments and treatmentInterval to icarMedicineCourseSummaryType Resolves adewg#219
Adjustments to the enumerated values for death event reasons and methods (kinds). Resolves adewg#224.
This reverts commit a040753.
This reverts commit 325e9b6.
This reverts commit 7bd093f.
Correct typo
|
just a small comment: |
|
It was felt that treatmentInterval was best specified in hours. You're right, it would be best as an integer. |
This was
linked to
issues
Jul 29, 2021
cookeac
added a commit
to cookeac/ICAR
that referenced
this pull request
Jul 29, 2021
Correct *treatmentInterval* in **icarMedicineCourseSummaryType.json** to an integer per [comment in 227](adewg#227 (comment))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.