Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional data for IcarMovementArrivalEventResource #431

Merged
merged 3 commits into from
Feb 1, 2024
Merged

Additional data for IcarMovementArrivalEventResource #431

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6f9c0d5
added parity, lastCalvingDate, lastInseminationDate, lastDryingOffDate
AndreasSchultzGEA Nov 17, 2023
dd4ec62
move the additional attributes from MovementEvent to AnimalCoreResource
AndreasSchultzGEA Nov 30, 2023
4592aa8
added icarAnimalStateType to the MovementEvent
AndreasSchultzGEA Nov 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions resources/icarAnimalCoreResource.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,22 @@
"$ref": "../enums/icarAnimalLactationStatusType.json",
"description": "Lactation status of the animal."
},
"parity": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"parity": {
"currentLactationParity": {

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cookeac, I changed as agreed on.

"type": "number",
"description": "The parity of the animal during this lactation."
},
"lastCalvingDate": {
"$ref": "../types/icarDateType.json",
"description": "RFC3339 UTC date (see https://ijmacd.github.io/rfc3339-iso8601/)."
},
"lastInseminationDate": {
"$ref": "../types/icarDateType.json",
"description": "RFC3339 UTC date (see https://ijmacd.github.io/rfc3339-iso8601/)."
},
"lastDryingOffDate": {
"$ref": "../types/icarDateType.json",
"description": "RFC3339 UTC date (see https://ijmacd.github.io/rfc3339-iso8601/)."
},
"parentage": {
"type": "array",
"description": "Parents of the animal. The array can handle multiple generations by specifying the parent of a parent.",
Expand Down
2 changes: 1 addition & 1 deletion resources/icarMovementArrivalEventResource.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,4 +23,4 @@
}
}
]
}
}