Additional data for IcarMovementArrivalEventResource #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I acknowledge some of this is covered by a lactation, but that this may not be immediately available to the destination farm during a movement. I'm not convinced that the solution is to add these fields to the movement event. We should look at adding them as optional status extensions to |
cookeac
reviewed
Nov 30, 2023
| @@ -81,6 +81,22 @@ | |||
| "$ref": "../enums/icarAnimalLactationStatusType.json", | |||
| "description": "Lactation status of the animal." | |||
| }, | |||
| "parity": { | |||
There was a problem hiding this comment.
Suggested change
| "parity": { | |
| "currentLactationParity": { |
There was a problem hiding this comment.
@cookeac, I changed as agreed on.
cookeac
approved these changes
Jan 25, 2024
erwinspeybroeck
approved these changes
Jan 29, 2024
|
Resolves #432 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our HM-System and at least in one of our partners, there is the request to enter additional information about an arriving animal which has taken place bevor the ArrivalEventDateTime.