Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change video to embed #9

Closed
wants to merge 1 commit into from
Closed

Change video to embed #9

wants to merge 1 commit into from

Conversation

Booom3
Copy link

@Booom3 Booom3 commented Jul 29, 2017

This lets the user fullscreen the video by pressing F11 which will
retain fullscreen through changing the page

Oh and it also fixes a bug with right click add to queue videos without "/watch?v=" in the URL, like such:
https://www.youtube.com/embed/UkWd0azv3fQ?autoplay=1

This lets the user fullscreen the video by pressing F11 which will
retain fullscreen through changing the page
@adeora7
Copy link
Owner

adeora7 commented Aug 22, 2017

Hey, sorry I didn't see the PR. I will verify now.

@adeora7
Copy link
Owner

adeora7 commented Aug 22, 2017

@Booom3 By changing to embed the suggestion which come on youtube will no longer be visible while video is playing. How will a person add more videos to the queue. He/she will have to go to another youtube tab to do so. Generally we add the videos related to the one which we are playing. So I don't think this is the solution. Also I didn't get which bug you are referencing here. Can you add an issue reference link for the same.

I tried to work on this issue but then starting working on something else. This is what can be done. you can create a variable in the local storage for full screen mode. The user can either have an option for that in the popup(strongly preferred) or you can map it to the youtube player full screen button. So whenever a new video plays, we check the local varibale for full screen mode and perform a click through in-page javascript on the youtube video player full screen button.

@Booom3
Copy link
Author

Booom3 commented Aug 27, 2017

This is true, I just personally don't use that. But you could just implement an option to toggle between the modes, to go embed link or regular link.

Your suggestion does not work as the browser will reject programmatic attempts to fullscreen the video. It keeps track of where events come from and if it tries to fullscreen the video through a click generated by the code it will fail.

@adeora7
Copy link
Owner

adeora7 commented Aug 27, 2017

@Booom3 I tried from the console and it works. I am not sure about the injected script. I will check and let you know.

@adeora7 adeora7 closed this Jan 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants