-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exits fullscreen on playing next video #8
Comments
yes, I was about to release a new version today. It will resolve this issue. Do checkout. Thank :) |
It does not seem to fix this issue. Where was your fix exactly? I am also a developer and is even maintaining my own Chrome/FF addon so I can take a look at the code. |
I didn't fix it yet. You can have a look at the in page script which sends a message to Content script via promise. There is a local variable in an object on top of background.js in which a new local variable for full screen can be added. On detecting full screen mode, send message from content.js to background.js to set variable and force it in whenever a new video is played either because one video ended or because someone explicitly played another one. |
Apparently this is completely impossible. Edit: The way it is now, that is. The way around it might be to switch to youtube.com/embed/ and let the user press F11 for fullscreen. |
Created a pull request to make the video use embed rather than the full youtube page. |
Pretty much what the title of the issue says.
Now I haven't looked at the code so correct me if I'm wrong but it seems like it simply redirects the tab to the next video and uses the standard browser code for playing the next video.
My solution to this problem would be to simply check if the video is fullscreen before redirecting and, if it is, maximizing the video player after the next tab is loaded. A bit hacky but it should work fine.
The text was updated successfully, but these errors were encountered: