-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vinyl #120
Vinyl #120
Conversation
try to guess source path of the file by checking relative links inside the html source show warning to the user when no relative links are available
some weird issue requires a second npm install to add all deps without this module minimist required by gulp-util is missing
still needs some work |
In index.js: exports.stream = function (opts) {
// ...
var options = _.assign(opts || {}, {
// src: file
src: file.path
});
// ... Seems to provide correct behavior in test cases. Should I open a new pull request? I don't know the etiquette here and I greatly appreciate how quickly you worked on this. 👍 |
@addyosmani wanna take a look? |
Yep. Sorry I've been out of town for a few weeks but I'll take a look. Thanks for working on this ⭐ |
Still needs some work (see #57) |
\o/ green again :) Added
@addyosmani: Want to take a look again? (Sorry for the 31 changed files ;)) |
Thanks for working on this! I'll take a look in the morning :) |
The list of changes here on the whole LGTM. To avoid blocking any further work here lets land it. |
This is a bigger maintenance PR. It includes the following improvements:
pathPrefix
automatically in most cases which drops the need for absolute asset paths. Asset paths will now stay relative (relative to the html file) if they were relative in the stylesheets (Base url #57,Styelsheet URL breaks when moving up in the directory "../" #95)