Styelsheet URL breaks when moving up in the directory "../"

[julienetie]

This:

     background: url('../folder/image.jpg');

becomes:

     background: url('folder/image.jpg');

It's not always convenient when taking src from a different directory (unless I'm doing something wrong) The same applies for multiple traversing. I found this but I'm not sure if the change will break anything:

lib/inline-styles.js

function rebaseRelativePaths(basePath, cssPath, cssStr) {
..//
                    for (var k = 0; k < pathDiff; k++) {
                        newPath = newPath.replace('../', '');
                    }
//..
}

Maybe remove the back tracking of dir could be better as an option.

[bezoerb]

@julienetie could you provide some more information about your setup?

[julienetie]

Sure:

So this is the css src

    background: #222 url('../funny-how.jpg') repeat-y;

which critical outputs into the html as:

    background: #222 url('funny-how.jpg') repeat-y;

gulpfile.js

gulp.task('build-404-critical-css', ['build-404-css'], function() {
    return critical.generateInline({
        base: './',
        src: './src/html/404.html',
        css: ['./style/404.min.css'],
        htmlTarget: './404/index.php',
        exclude: true,
        width: 1366,
        height: 4000,
        minify: true
    });
});

[bezoerb]

@julienetie i've made some tests but i couldn't reproduce your issue.
The background-image in the critical css always resolves to url('/funny-how.jpg')

Which version of critical are using?

[bezoerb]

You also could use the stream method when using with gulp.

[julienetie]

Thanks @bezoerb, I'll give it a try.

[bezoerb]

@julienetie any updates on this one?

[SerzN1]

You must use option
pathPrefix: '/' + yourPath
Your code will be immediately on the page.

[bezoerb]

We've made some progress on this topic @julienetie. The asset paths inside the critical css should now stay relative in case they were relative the first place. Could you check if your issue is fixed in the vinyl branch?

npm install --save-dev git+https://github.com/addyosmani/critical.git#vinyl

/cc @SerzN1

[bezoerb]

Closing this due to lack of feedback. Feel free to reopen if you still got problems on this one.