update setup

[adbar]

No description provided.

[github-advanced-security]

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.05%. Comparing base (6586bcb) to head (66d93bc).

Additional details and impacted files

@@             Coverage Diff             @@
##             main     #119       +/-   ##
===========================================
- Coverage   96.62%   81.05%   -15.57%     
===========================================
  Files          33       35        +2     
  Lines         651      776      +125     
===========================================
  Hits          629      629               
- Misses         22      147      +125     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[adbar]

@juanjoDiaz I'm trying to make a fresh start before working on the rest, do you know why the tests fail?

[adbar]

Additional note: on my computer the language detection tests are failing but not the rest.

[juanjoDiaz]

Hi @adbar ,

I just rebased #116 and tests are passing just fine.
I also run all tests from main on my local and they worked just fine.
So, the issue has to be something that you have changed in this PR.

All the failing tests exit with code 2, which means that the job was cancelled (probably because some other job failed).
Only tests (windows-latest, 3.8, true, true) exists with code 1 but doesn't show any different details.

Btw, is there any reason to don't merge outstanding PRs with passing tests before going back into new things?
I recently has to explain to someone how all the classes work and it was quite tedious without the public documentation introduced in #109.

[adbar]

Hi @juanjoDiaz, thanks for the prompt answer. I confirm that the tests now work on my machine but there seems to be an issue with the configuration for Github CI/CD here, I'm not sure where.

The PRs where a lot to process and we missed each other due to our longer/summer holidays last year, after that I didn't have much time but I can now move forward towards version 1. I'll have a look at the docs next.

[adbar]

Note: "calling via python will also add the current directory to sys.path" (pytest docs).