Update sharing options #2346
Merged
Update sharing options #2346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moloko
approved these changes
Feb 5, 2019
lc-thomasberger
approved these changes
Feb 5, 2019
NayanKhedkar
approved these changes
Feb 6, 2019
|
Apologies because I'm not so familiar with the framework side of things I just wanted to check... @taylortom I think this change will need to be in framework version 2,3 & 4. Is this PR going to achieve that? I think you might need to make a PR to the legacy branch? |
|
Discussed in the authoring tool standup and we think there should also be a PR to the legacy branch to avoid confusion caused by having this in some places and not others |
cahirodoherty-learningpool
approved these changes
May 1, 2019
moloko
approved these changes
May 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2345.
💀 Need to discuss exactly when this should be merged, as it will break authoring tools older than v0.7.0 due to the new
Usersinput type.