Share course with specific users #2204

taylortom · 2019-01-28T13:12:06Z

Fixes #2123 (framework issue #2345).

Also removed the unused shared project view and associated files.

lib/role/CourseCreator.json

taylortom · 2019-01-28T13:21:50Z

plugins/content/course/model.schema

      "help": "Controls whether or not your colleagues will be able to see this course from the 'Shared courses' option"
    },
+    "_shareWithUsers": {


Adds extra sharing field

TomG's PR is going to mean that these schemas get pulled in from the framework (#2185) so I think that putting this here will mean that it is overwritten

Have opened a framework PR here: adaptlearning/adapt_framework#2346

canstudios-nicolaw · 2019-02-01T10:08:15Z

plugins/content/course/model.schema

      "help": "Controls whether or not your colleagues will be able to see this course from the 'Shared courses' option"
    },
+    "_shareWithUsers": {


TomG's PR is going to mean that these schemas get pulled in from the framework (#2185) so I think that putting this here will mean that it is overwritten

lib/helpers.js

lc-thomasberger · 2019-02-14T09:19:36Z

When I share a course with all users, other users can't see the course.
Only if it is shared with a certain user the course is displayed in "shared courses".

lc-thomasberger · 2019-02-14T09:21:06Z

A course that is shared with all users can't be deleted by the user that created it.

taylortom · 2019-02-15T19:00:20Z

This is working with #1926, so will get that one merged first before looking again.

# Conflicts: # frontend/src/modules/projects/index.js # frontend/src/modules/projects/views/projectsView.js # frontend/src/modules/scaffold/index.js # lib/helpers.js # plugins/content/course/index.js

canstudios-nicolaw · 2019-02-20T14:00:43Z

@taylortom Would you expect anything to be required to test this other than npm install, grunt build and a restart?

I am getting a lot of errors in the console when I try and view dashboards or courses

I can see _shareWithUsers in my course model.schema, I'm testing on an install that existed before TomG's schema release so I think it is using the schemas in the authoring tool.

I will try and investigate this now but just wanted to check I'm not missing something

Update: I hadn't realised we need to test with a version of the framework that contains the schema change (adaptlearning/adapt_framework#2351 or adaptlearning/adapt_framework#2346)

canstudios-nicolaw · 2019-02-20T15:45:05Z

If I log in and share the course with a user, then that user does appear to be able to edit, delete, download and export the course but they cannot preview it - this gives a 401 permission denied
If I share the course with User A, then User A can share the course with everyone. This is a new scenario that we won't have come across before. Should the course owner be the only person who can share a course with everyone?
I think it's a little strange that if I share a course with somebody I don't really have any way to see that from the dashboard. I think I would have expected to see it on the shared courses dashboard because it has been shared with somebody. The sharing settings are right next to each other in the project settings so I would hope that upon opening the course from there it would be easy to determine the type of sharing. I'm open to other opinions on this

taylortom · 2019-02-21T12:09:57Z

Good questions,

Will have a look into this one.
This is as designed, the thinking being if you have permission to edit (and delete) a course, then why not permission to change the sharing settings. If we agree on a different strategy, happy to change it.
I think this is more a failing of the dashboard in general - I've never liked the separate pages for mine/shared. Think a better approach would be to merge the two, and use filters/views to alter what's displayed. I also think we need a set of icons to show more info about each course (i.e. mine, shared, ... possibly other stuff)

canstudios-nicolaw · 2019-02-21T13:06:26Z

Ok thanks @taylortom

I'm fine with 2 & 3 for now then 👍

canstudios-nicolaw

If I tick the 'share with all users' box and don't share the course with any specific user then:

I cannot see the course in the shared courses dashboard
Super admins in the system can see the course on the shared courses dashboard
Course creators in the system cannot see the course on the shared courses dashboard

lc-thomasberger · 2019-02-25T09:37:11Z

I can replicate @canstudios-nicolaw issue above.

# Conflicts: # frontend/src/modules/projects/index.js # frontend/src/modules/projects/views/projectsView.js # lib/helpers.js # plugins/content/course/index.js

canstudios-nicolaw · 2019-02-26T09:00:12Z

@taylortom I'm still having one of the issues above, if I share a course via the 'share with all' checkbox then I don't see it on my shared courses dashboard. This issue occurs whether I have also shared with some individuals or not. The rest is working well now though 👍

lc-thomasberger · 2019-02-26T09:53:49Z

I can not replicate. @canstudios-nicolaw can you please check your tenants?

taylortom · 2019-02-26T10:11:32Z

@lc-thomasberger @canstudios-nicolaw I think this is related to courses which you own? I changed the API query slightly to omit any shared courses not owned by you (as they're already shown in 'My courses'). Will revert this in light of the upcoming #2238

taylortom and others added 21 commits September 17, 2018 16:50

Add front-end

cd1ac09

Fix helper

a058fad

Refactor middleware

0554a22

Update role permissions

c50e0fa

Refactor API endpoints to work with new sharing

4f94533

Remove sharedProjectView

92bce35

Remove model attribute

4bcd32b

Filter out me

4d49532

Fix query

e62406e

Update lang strings

8b9360a

Add population to user route

c53a3ae

Refactor route to allow querying

2811e62

Fix function

7032d8b

Add creator to projectView

457b84f

Refactor permissions

fedccf3

Remove comment

c5eaf9a

Update title text

e5a6b55

Update selectize

d93666e

Add common selectize less

c25966e

Update input

89c5cab

Add error message

3d22155

taylortom added this to the 0.7.0 Loose ends milestone Jan 28, 2019

Merge branch 'develop' into feature/sharing

d0f9016

taylortom commented Jan 28, 2019

View reviewed changes

lib/role/CourseCreator.json Show resolved Hide resolved

taylortom commented Jan 28, 2019

View reviewed changes

taylortom changed the title ~~Feature/sharing~~ Share course with specific users Jan 28, 2019

taylortom changed the base branch from develop to release/0.7.0 January 28, 2019 13:22

lc-thomasberger mentioned this pull request Jan 31, 2019

share course with specific user #2203

Closed

canstudios-nicolaw reviewed Feb 1, 2019

View reviewed changes

taylortom mentioned this pull request Feb 6, 2019

Revisit dashboard sorting #2211

Closed

Merge branch 'release/0.7.0' into feature/sharing

cc85190

# Conflicts: # frontend/src/modules/projects/index.js # frontend/src/modules/projects/views/projectsView.js # frontend/src/modules/scaffold/index.js # lib/helpers.js # plugins/content/course/index.js

taylortom added the S: in-progress Issues currently being worked on - leave these be! label Feb 20, 2019

taylortom added 2 commits February 20, 2019 12:09

Reapply changes lost in merge

aaef746

Make selectize styling consistent

4dc17f2

taylortom removed the S: in-progress Issues currently being worked on - leave these be! label Feb 20, 2019

taylortom added 2 commits February 22, 2019 17:32

Remove helper

7eee01e

Refactor to fix permissions issue

7c960dd

canstudios-nicolaw reviewed Feb 25, 2019

View reviewed changes

taylortom added 2 commits February 25, 2019 13:19

Add defensive programming for courses without a creator

95230e0

Fix permissions check

8d62a16

lc-thomasberger added the merge-conflicts label Feb 25, 2019

Merge branch 'release/0.7.0' into feature/sharing

63434b4

# Conflicts: # frontend/src/modules/projects/index.js # frontend/src/modules/projects/views/projectsView.js # lib/helpers.js # plugins/content/course/index.js

taylortom removed the merge-conflicts label Feb 25, 2019

lc-thomasberger approved these changes Feb 25, 2019

View reviewed changes

Alter shared courses query

c5e9efa

canstudios-nicolaw approved these changes Feb 26, 2019

View reviewed changes

lc-thomasberger approved these changes Feb 26, 2019

View reviewed changes

taylortom merged commit b074e78 into adaptlearning:release/0.7.0 Feb 26, 2019

taylortom deleted the feature/sharing branch February 26, 2019 14:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Share course with specific users #2204

Share course with specific users #2204

taylortom commented Jan 28, 2019 •

edited

Loading

taylortom Jan 28, 2019

canstudios-nicolaw Feb 1, 2019

taylortom Feb 5, 2019

canstudios-nicolaw Feb 1, 2019

lc-thomasberger commented Feb 14, 2019 •

edited

Loading

lc-thomasberger commented Feb 14, 2019

taylortom commented Feb 15, 2019

canstudios-nicolaw commented Feb 20, 2019 •

edited

Loading

canstudios-nicolaw commented Feb 20, 2019 •

edited by taylortom

Loading

taylortom commented Feb 21, 2019 •

edited

Loading

canstudios-nicolaw commented Feb 21, 2019

canstudios-nicolaw left a comment

lc-thomasberger commented Feb 25, 2019

canstudios-nicolaw commented Feb 26, 2019

lc-thomasberger commented Feb 26, 2019

taylortom commented Feb 26, 2019 •

edited

Loading

Share course with specific users #2204

Share course with specific users #2204

Conversation

taylortom commented Jan 28, 2019 • edited Loading

taylortom Jan 28, 2019

Choose a reason for hiding this comment

canstudios-nicolaw Feb 1, 2019

Choose a reason for hiding this comment

taylortom Feb 5, 2019

Choose a reason for hiding this comment

canstudios-nicolaw Feb 1, 2019

Choose a reason for hiding this comment

lc-thomasberger commented Feb 14, 2019 • edited Loading

lc-thomasberger commented Feb 14, 2019

taylortom commented Feb 15, 2019

canstudios-nicolaw commented Feb 20, 2019 • edited Loading

canstudios-nicolaw commented Feb 20, 2019 • edited by taylortom Loading

taylortom commented Feb 21, 2019 • edited Loading

canstudios-nicolaw commented Feb 21, 2019

canstudios-nicolaw left a comment

Choose a reason for hiding this comment

lc-thomasberger commented Feb 25, 2019

canstudios-nicolaw commented Feb 26, 2019

lc-thomasberger commented Feb 26, 2019

taylortom commented Feb 26, 2019 • edited Loading

taylortom commented Jan 28, 2019 •

edited

Loading

lc-thomasberger commented Feb 14, 2019 •

edited

Loading

canstudios-nicolaw commented Feb 20, 2019 •

edited

Loading

canstudios-nicolaw commented Feb 20, 2019 •

edited by taylortom

Loading

taylortom commented Feb 21, 2019 •

edited

Loading

taylortom commented Feb 26, 2019 •

edited

Loading