Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create aria label for partly correct answers #3565

Closed
kirsty-hames opened this issue Jun 5, 2024 · 1 comment · Fixed by #3570
Closed

Create aria label for partly correct answers #3565

kirsty-hames opened this issue Jun 5, 2024 · 1 comment · Fixed by #3570
Assignees
@kirsty-hames
Labels
accessibility enhancement released

Comments

@kirsty-hames
Copy link
Contributor

Subject of the enhancement

There is no aria label for partially correct question answers. See original issue raised. See existing labels below.

course.json

adapt_framework/src/course/en/course.json

Lines 46 to 47 in 917b161

"answeredIncorrectly": "You answered incorrectly",
"answeredCorrectly": "You answered correctly",

adapt_framework/src/course/en/course.json

Lines 62 to 63 in 917b161

"incorrect": "Incorrect",
"correct": "Correct",

buttonsView.js
https://github.com/adaptlearning/adapt-contrib-core/blob/4b8a99ab60704bb6d6993992ceae575b86a120c7/js/views/buttonsView.js#L188-L194

Expected behaviour

An aria label should exist for correct, partially correct and incorrect.
@kirsty-hames kirsty-hames mentioned this issue Jun 5, 2024
Merged
@kirsty-hames kirsty-hames self-assigned this Jun 6, 2024
@kirsty-hames kirsty-hames moved this from New to Assigned in adapt_framework: The TODO Board Jun 6, 2024
This was referenced Jun 10, 2024
Closed
Merged
@kirsty-hames kirsty-hames moved this from Assigned to Needs Reviewing in adapt_framework: The TODO Board Jun 10, 2024
joe-allen-89 pushed a commit that referenced this issue Jun 11, 2024
@kirsty-hames @oliverfoster
@semantic-release-bot @swashbuck
New: partly correct aria labels added to course _globals (fixes #3565) (
fcd6bab 
#3570)

* partly correct aria labels added to course _globals

* merge master into issue/3565 (#3569)

* Fix: Bumping core to v6.49.0 automatically via 'frameworkpullrequest' Github action (#3564)

Co-authored-by: oliverfoster <[email protected]>

* Chore(release): 5.39.8 [skip ci]

## [5.39.8](v5.39.7...v5.39.8) (2024-06-07)

### Fix

* Bumping core to v6.49.0 automatically via 'frameworkpullrequest' Github action (#3564) ([514449a](514449a)), closes [#3564](#3564)

* Fix: Remove values for _feedback._altTitle in sample course (fixes #3567)

* Chore(release): 5.39.9 [skip ci]

## [5.39.9](v5.39.8...v5.39.9) (2024-06-07)

### Fix

* Remove values for _feedback._altTitle in sample course (fixes #3567) ([a0e03c0](a0e03c0)), closes [#3567](#3567)

* Fix: Default to secure connection for bower registry (fixes #3550)

* Chore(release): 5.39.10 [skip ci]

## [5.39.10](v5.39.9...v5.39.10) (2024-06-07)

### Fix

* Default to secure connection for bower registry (fixes #3550) ([8594304](8594304)), closes [#3550](#3550)

* Fix: Bumping core to v6.50.0 automatically via 'frameworkpullrequest' Github action (#3568)

Co-authored-by: oliverfoster <[email protected]>

* Chore(release): 5.39.11 [skip ci]

## [5.39.11](v5.39.10...v5.39.11) (2024-06-07)

### Fix

* Bumping core to v6.50.0 automatically via 'frameworkpullrequest' Github action (#3568) ([fda22a8](fda22a8)), closes [#3568](#3568)

---------

Co-authored-by: Oliver Foster <[email protected]>
Co-authored-by: oliverfoster <[email protected]>
Co-authored-by: semantic-release-bot <[email protected]>
Co-authored-by: Brad Simpson <[email protected]>

* resolve package-lock.json conflicts

* resolve .gitmodules conflicts

* resolve package.json conflicts

* resolve package-lock.json conflicts

---------

Co-authored-by: Oliver Foster <[email protected]>
Co-authored-by: oliverfoster <[email protected]>
Co-authored-by: semantic-release-bot <[email protected]>
Co-authored-by: Brad Simpson <[email protected]>
@github-project-automation github-project-automation bot moved this from Needs Reviewing to Recently Released in adapt_framework: The TODO Board Jun 11, 2024
github-actions bot pushed a commit that referenced this issue Jun 26, 2024
@semantic-release-bot
Chore(release): 5.40.0 [skip ci]
4469a94 
# [5.40.0](v5.39.15...v5.40.0) (2024-06-26)

### Fix

* Bumping core to v6.52.0 automatically via 'frameworkpullrequest' Github action (#3579) ([a226704](a226704)), closes [#3579](#3579)

### New

* partly correct aria labels added to course _globals (fixes #3565) (#3570) ([fcd6bab](fcd6bab)), closes [#3565](#3565) [#3570](#3570) [#3569](#3569) [#3564](#3564) [#3564](#3564) [#3567](#3567) [#3567](#3567) [#3567](#3567) [#3550](#3550) [#3550](#3550) [#3550](#3550) [#3568](#3568) [#3568](#3568)
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 5.40.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kirsty-hames kirsty-hames

Labels
accessibility enhancement released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

New: partly correct aria labels added to course _globals (fixes #3565) adaptlearning/adapt_framework
1 participant
@kirsty-hames