Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New: Added correctness classes to progress bars and arialabels to drawer buttons #225

Merged
merged 6 commits into from
Jun 12, 2024
Merged

New: Added correctness classes to progress bars and arialabels to drawer buttons #225

merged 6 commits into from
Jun 12, 2024

Conversation

oliverfoster
Copy link
Member

@oliverfoster oliverfoster commented May 22, 2024 •
edited
Loading

fixes #224

Fix

  • Added correctness classes to progress bars
  • Added correctness arialabels to drawer buttons

@oliverfoster oliverfoster self-assigned this May 22, 2024
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@oliverfoster
Revert to completion calculation
b7905a0 
As the completion calculation can be overridden and will change the concept of complete for the plp status e.g. for assessment pass requirements etc.
swashbuck
swashbuck approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@swashbuck swashbuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

kirsty-hames
kirsty-hames reviewed May 28, 2024
View reviewed changes
Copy link
Contributor

@kirsty-hames kirsty-hames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works as expected thanks. I just have a couple of queries...

  1. Should .is-partially-correct class be included for consistency with Tutor classes.
  2. Should the aria-label include correctness labels too?

@oliverfoster
Copy link
Member Author

oliverfoster commented Jun 4, 2024 •
edited
Loading

This works as expected thanks. I just have a couple of queries...

  1. Should .is-partially-correct class be included for consistency with Tutor classes.
  2. Should the aria-label include correctness labels too?

I notice that we don't have an aria label for partly correct. Do we need to add one? It would make sense to me.

course.json

https://github.com/adaptlearning/adapt_framework/blob/917b16180a57a8ed3c492c99da4531910fb62660/src/course/en/course.json#L46-L47
https://github.com/adaptlearning/adapt_framework/blob/917b16180a57a8ed3c492c99da4531910fb62660/src/course/en/course.json#L62-L63

buttonsView.js

https://github.com/adaptlearning/adapt-contrib-core/blob/4b8a99ab60704bb6d6993992ceae575b86a120c7/js/views/buttonsView.js#L188-L194

kirsty-hames
kirsty-hames approved these changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@kirsty-hames kirsty-hames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected thanks 👍

@kirsty-hames kirsty-hames mentioned this pull request Jun 5, 2024
Closed
@kirsty-hames
Copy link
Contributor

This works as expected thanks. I just have a couple of queries...

  1. Should .is-partially-correct class be included for consistency with Tutor classes.
  2. Should the aria-label include correctness labels too?

I notice that we don't have an aria label for partly correct. Do we need to add one? It would make sense to me.

course.json

https://github.com/adaptlearning/adapt_framework/blob/917b16180a57a8ed3c492c99da4531910fb62660/src/course/en/course.json#L46-L47 https://github.com/adaptlearning/adapt_framework/blob/917b16180a57a8ed3c492c99da4531910fb62660/src/course/en/course.json#L62-L63

buttonsView.js

https://github.com/adaptlearning/adapt-contrib-core/blob/4b8a99ab60704bb6d6993992ceae575b86a120c7/js/views/buttonsView.js#L188-L194

Agreed. Issue raised adaptlearning/adapt_framework#3565

@oliverfoster
Copy link
Member Author

I haven't included the arialabels for the plp drawer items yet. I'll wait for the issue mentioned to be resolved.

@kirsty-hames
Copy link
Contributor

adaptlearning/adapt_framework#3565

I haven't included the arialabels for the plp drawer items yet. I'll wait for the issue mentioned to be resolved.

PR ready for review adaptlearning/adapt_framework#3570

@oliverfoster oliverfoster changed the title New: Added correctness classes to progress bars New: Added correctness classes to progress bars and arialabels to buttons Jun 12, 2024
@oliverfoster oliverfoster changed the title New: Added correctness classes to progress bars and arialabels to buttons New: Added correctness classes to progress bars and arialabels to drawer buttons Jun 12, 2024
@oliverfoster oliverfoster mentioned this pull request Jun 12, 2024
Merged
@oliverfoster
Copy link
Member Author

This has the aria labels in it now, and support for _canShowMarking. Could you re-review please? @kirsty-hames

kirsty-hames
kirsty-hames approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@kirsty-hames kirsty-hames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works as expected thanks 👍

@oliverfoster oliverfoster merged commit 9b4e8a7 into master Jun 12, 2024
@oliverfoster oliverfoster deleted the issue/224 branch June 12, 2024 09:05
github-actions bot pushed a commit that referenced this pull request Jun 12, 2024
@semantic-release-bot
Chore(release): 7.9.0 [skip ci]
df1ae02 
# [7.9.0](v7.8.1...v7.9.0) (2024-06-12)

### New

* Added correctness classes to progress bars and arialabels to drawer buttons (#225) ([9b4e8a7](9b4e8a7)), closes [#225](#225)
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 7.9.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@kirsty-hames kirsty-hames kirsty-hames approved these changes

@swashbuck swashbuck swashbuck approved these changes

Assignees

@oliverfoster oliverfoster

Labels
enhancement released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add correctness class to progress bars
4 participants
@oliverfoster @kirsty-hames @swashbuck @cahirodoherty-learningpool