fixes #1611 #1612
Merged
fixes #1611 #1612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dancgray
reviewed
Apr 7, 2017
| var supportedLayout = properties.hasOwnProperty('._supportedLayout').enum; | ||
| if (properties && properties.hasOwnProperty('_supportedLayout')) { | ||
| var supportedLayout = properties._supportedLayout.enum; | ||
| var availablePositions = { |
There was a problem hiding this comment.
@danielstorey I think availablePositions is also used to find positions that are not already occupied as set in setupFilters function. Assigning a new value to availablePositions here allows the user to insert two left (or right) positioned components.
There was a problem hiding this comment.
Ok good point...so just need to combine both checks
There was a problem hiding this comment.
Latest commit should do it!
dancgray
approved these changes
Apr 7, 2017
barry-mckay
approved these changes
Apr 26, 2017
brian-learningpool
approved these changes
Apr 27, 2017
There was a problem hiding this comment.
Nice job, @danielstorey! This has been an issue for some time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_supportedLayout was not working at all meaning left, right and full were always available even if a plugin's properties.schema was limited to
half-widthorfull-widthonly. This PR addresses the issue in two areas:Sidebar component list - when a component is selected only the options specified in the properties schema are available.
Page editor - if a component is full-width only then the
component-movearrow icons will not be rendered. If half width only then the full width arrow will not be rendered