Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Full width only components can still be dragged left or right into an empty block #1631

Closed
danielstorey opened this issue May 11, 2017 · 0 comments
Closed

Full width only components can still be dragged left or right into an empty block #1631

danielstorey opened this issue May 11, 2017 · 0 comments
Milestone
0.4.0 Refactor

Comments

@danielstorey
Copy link
Member

This is related to #1611 which was partially fixed in #1612.

Steps to reproduce:

  • Create a block
  • Add a full width only component to the block
    Placement and movement within the initial block will be restricted to full only which is the desired effect
  • Add a new block
  • Drag the above component into the new block

Expected result:
Only the full width option should be enabled

Actual result:
Left and right options are enabled as well
danielstorey added a commit to danielstorey/adapt_authoring that referenced this issue May 11, 2017
@danielstorey
Fixes adaptlearning#1631
9a79f7f 
Pass a supportedLayout object to the showDropZones method defined in the editorOriginView so that only the appropriate drop zones are displayed when dragging a component from one block to another.
danielstorey added a commit to danielstorey/adapt_authoring that referenced this issue May 11, 2017
@danielstorey
Fixes adaptlearning#1631
aa0d7fa 
Pass a supportedLayout object to the showDropZones method defined in the editorOriginView so that only the appropriate drop zones are displayed when dragging a component from one block to another.
taylortom added a commit that referenced this issue Aug 24, 2017
@taylortom
Merge pull request #1632 from danielstorey/issue/1631
a317ee5 
Fixes #1631
@taylortom taylortom added this to the 0.4.0 Refactor milestone Aug 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.4.0 Refactor
Development

No branches or pull requests
2 participants
@taylortom @danielstorey