Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Convert to JSX (fixes #238) #250

Merged
merged 26 commits into from
Mar 21, 2023
Merged

Fix: Convert to JSX (fixes #238) #250

merged 26 commits into from
Mar 21, 2023

Conversation

swashbuck
Copy link
Contributor

@swashbuck swashbuck commented Feb 22, 2023 •
edited
Loading

Fixes #238

Fix

  • Converts .hbs template to .jsx
  • Progress indicator navigation not reachable by keyboard #244 Progress dots - make non-interactive
  • Add style for mobile instruction error. "In mobile view, highlight instruction if user navigates to another item before completing, in case the strapline is missed"
  • No change to how touch/swipe controls work (jQuery).
  • Replaced user-drag CSS property with draggable HTML property
  • Checks the user's system prefers-reduced-motion preference and disables animations if necessary

Dependencies

adaptlearning/adapt-contrib-vanilla#398 Remove hover state styling from the progress indicators

@swashbuck swashbuck self-assigned this Feb 22, 2023
@swashbuck
Copy link
Contributor Author

swashbuck commented Feb 22, 2023 •
edited
Loading

Still outstanding before we can take this PR out of draft:

@swashbuck swashbuck mentioned this pull request Mar 3, 2023
Closed
@swashbuck swashbuck marked this pull request as ready for review March 3, 2023 22:53
@swashbuck
Copy link
Contributor Author

Ready for review.

@StuartNicholls
Copy link

@swashbuck I can see the pips are now no longer selectable but the hover states in the css are still there

@swashbuck swashbuck mentioned this pull request Mar 9, 2023
Closed
@swashbuck
Copy link
Contributor Author

@swashbuck I can see the pips are now no longer selectable but the hover states in the css are still there

@StuartNicholls I've created adaptlearning/adapt-contrib-vanilla#398 to remove the hover states.

@swashbuck swashbuck mentioned this pull request Mar 9, 2023
Merged
kirsty-hames
kirsty-hames reviewed Mar 13, 2023
View reviewed changes
less/narrative.less Outdated Show resolved Hide resolved
@swashbuck swashbuck mentioned this pull request Mar 13, 2023
Closed
@swashbuck swashbuck mentioned this pull request Mar 13, 2023
Merged
@swashbuck swashbuck requested a review from kirsty-hames March 15, 2023 15:44
kirsty-hames
kirsty-hames approved these changes Mar 21, 2023
View reviewed changes
Copy link
Contributor

@kirsty-hames kirsty-hames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Mac Safari, FF and Chrome. Android tablet, iPhone and iPad.
Screen reader tested with voiceOver.

@swashbuck swashbuck merged commit 7f7977a into master Mar 21, 2023
@swashbuck swashbuck deleted the issue/238 branch March 21, 2023 14:39
@github-actions
Copy link

🎉 This PR is included in version 7.4.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@swashbuck swashbuck mentioned this pull request Jul 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverfoster oliverfoster oliverfoster left review comments

@eleanor-heath eleanor-heath eleanor-heath approved these changes

@kirsty-hames kirsty-hames kirsty-hames approved these changes

@StuartNicholls StuartNicholls StuartNicholls approved these changes

@chris-steele chris-steele Awaiting requested review from chris-steele

Assignees

@swashbuck swashbuck

Labels
enhancement released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert to JSX
5 participants
@swashbuck @StuartNicholls @kirsty-hames @oliverfoster @eleanor-heath