Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add intruction error icons #328

Closed
swashbuck opened this issue Mar 13, 2023 · 1 comment · Fixed by #329
Closed

Add intruction error icons #328

swashbuck opened this issue Mar 13, 2023 · 1 comment · Fixed by #329
Assignees
@swashbuck
Labels
accessibility enhancement New feature or request released

Comments

@swashbuck
Copy link
Contributor

swashbuck commented Mar 13, 2023 •
edited
Loading

Subject of the enhancement

The Narrative component needs to highlight the instruction text with error styles and an icon. This could be applied to other components as well or even articles and blocks.

This implementation should hide the icon from screen readers and, because of this, is preferred to using a pseudo-selector for the icon.

adaptlearning/adapt-contrib-narrative#250

Shout out to @kirsty-hames for this idea.
@swashbuck swashbuck self-assigned this Mar 13, 2023
@swashbuck swashbuck added enhancement New feature or request accessibility labels Mar 13, 2023
@swashbuck swashbuck mentioned this issue Mar 13, 2023
Merged
@swashbuck swashbuck moved this from New to Needs Reviewing in adapt_framework: The TODO Board Mar 13, 2023
swashbuck added a commit that referenced this issue Mar 14, 2023
@swashbuck
New: Add icon span to instruction element in header.jsx (fixes #328)
c1fb6c8 
* Add icon span element to instruction element in header.jsx
* Add icon span element to component instruction in hbs template
@github-project-automation github-project-automation bot moved this from Needs Reviewing to Recently Released in adapt_framework: The TODO Board Mar 14, 2023
github-actions bot pushed a commit that referenced this issue Mar 14, 2023
@semantic-release-bot
Chore(release): 6.27.0 [skip ci]
a20c21a 
# [6.27.0](v6.26.0...v6.27.0) (2023-03-14)

### New

* Add icon span to instruction element in header.jsx (fixes #328) ([c1fb6c8](c1fb6c8)), closes [#328](#328)
@github-actions
Copy link

🎉 This issue has been resolved in version 6.27.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@swashbuck swashbuck

Labels
accessibility enhancement New feature or request released
Projects
None yet
Milestone
No milestone
1 participant
@swashbuck