Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set ROOT to top_builddir #43

Closed
wants to merge 1 commit into from

Conversation

proski
Copy link

@proski proski commented Feb 5, 2023

Building with MSYS2 was failing due to the command line for linking glib DLL exceeding the sh.exe limit of 8192 bytes. When sh.exe from MSYS2 was present in PATH, gmake would use it and run a truncated command.

Using relative filenames shortens that command line to about 5k regardless of the source directory location.

@proski
Copy link
Author

proski commented Feb 5, 2023

This PR is for topic/build-228, I understand that';s the current "development branch".
I'm not a fan of ?= for variables essential for the build. It's more appropriate for VERBOSE and other superficial stuff.
I'm not sure about the impact on other projectd, maybe $(top_builddir) should be used instead of $(ROOT) in the makefiles to avoid unnecessary indirection.

@proski
Copy link
Author

proski commented Feb 6, 2023

By the way, it should be possible to make win32 builds more similar to the autotools builds.
Current directory structure:

root = top_builddir = top_scrdir
    bin.compiler
        release
            binaries
    lib.compiler
        release
            libraries
    obj.compiler
        release
            object files

Better structure:

root = top_scrdir
    release.compiler = top_builddir
        bin
            binaries
        lib
            libraries
        obj
            object files

As the next step, the generated makefiles could be created under top_builddir, allowing multiple builds from the same source to be run in parallel.

Building with MSYS2 was failing due to the command line for linking glib
DLL exceeding the sh.exe limit of 8192 bytes. When sh.exe from MSYS2 was
present in PATH, gmake would use it and run a truncated command.

Using relative filenames shortens that command line to about 5k
regardless of the source directory location.
@Neustradamus
Copy link

@adamyg: Why this PR has been closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants