Use top_builddir instead of ROOT #40
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Building with MSYS2 was failing due to the command line for linking glib DLL exceeding the sh.exe limit of 8192 bytes. When sh.exe from MSYS2 was present in PATH, gmake would use it and run a truncated command. Using relative filenames shortens that command line to about 5k regardless of the source directory location. The use of absolute paths to any files in the build directory should be strongly discouraged, as the build should not keep memory of the location where it was built. Replace ROOT with top_builddir everywhere. The ROOT variable was not named correctly, the standard name is abs_top_builddir and it remains available in case it's ever needed.
|
With this issue resolved, we won't need GnuWin32 anymore, we could recommend Git for Windows or MSYS2. Since they both have |
|
nothing against ROOT ?=@top_builddir@; also considering @SET_ROOT@ |
|
Closing in favor of #43 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building with MSYS2 was failing due to the command line for linking glib DLL exceeding the sh.exe limit of 8192 bytes. When sh.exe from MSYS2 was present in PATH, gmake would use it and run a truncated command.
Using relative filenames shortens that command line to about 5k regardless of the source directory location.
The use of absolute paths to any files in the build directory should be strongly discouraged, as the build should not keep memory of the location where it was built.
Replace ROOT with top_builddir everywhere. The ROOT variable was not named correctly, the standard name is abs_top_builddir and it remains available in case it's ever needed.