Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alternate i2c bus support #5

Merged
merged 2 commits into from
Sep 19, 2023
Merged

Conversation

tyeth
Copy link

@tyeth tyeth commented Sep 19, 2023

This is a change to add an extra constructor definition that supports passing a TwoWire object as well as the device address.

Tested as part of WipperSnapper firmware change
adafruit/Adafruit_Wippersnapper_Arduino#491

On Feather ESP32v2 and qtpyESP32s2

@tyeth tyeth requested a review from caternuson September 19, 2023 16:13
@tyeth
Copy link
Author

tyeth commented Sep 19, 2023

@caternuson really appreciate if you could cast a quick eye over this

src/ScioSense_ENS160.h Outdated Show resolved Hide resolved
@tyeth
Copy link
Author

tyeth commented Sep 19, 2023

Thanks @caternuson for the eagle eye, hopefully that's alright now the signature in the header file is resolved.

@caternuson
Copy link

Just to note - we'd probably have this stuff be in begin() instead of the ctor if this had originated with Adafruit. But since this is a fork, sort of stuck with the original interface design.

@caternuson
Copy link

Would also be nice to have CI at some point to catch things :(

@tyeth
Copy link
Author

tyeth commented Sep 19, 2023

Definitely to both. I get the list of non-CI'd repo's each week so it's mentally on the todo list and likely to be not forgotten as it'll reduce the list of non-action results from adabot. Glad Adafruit is a fan of CI/automation in general

@tyeth tyeth merged commit 39722e0 into adafruit:master Sep 19, 2023
@tyeth tyeth deleted the add-twowire-param branch September 19, 2023 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants