Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial ENS160 code #491

Merged
merged 3 commits into from
Sep 20, 2023
Merged

Initial ENS160 code #491

merged 3 commits into from
Sep 20, 2023

Conversation

tyeth
Copy link
Contributor

@tyeth tyeth commented Sep 19, 2023

This adds support for the ENS160.

Blocked by adafruit/ENS160_driver#5

Tested with two on the bus, Feather ESP32v2

image

@tyeth
Copy link
Contributor Author

tyeth commented Sep 19, 2023

@brentru ready for a review.
I've locally modified the platformio.ini to use my PR branch for the ens160 driver.
I've asked Carter to have a quick look at that PR, which will unblock this for CI + merge.

@brentru
Copy link
Member

brentru commented Sep 19, 2023

Will review once unblocked by arduino library

@tyeth tyeth marked this pull request as ready for review September 19, 2023 20:42
@tyeth
Copy link
Contributor Author

tyeth commented Sep 19, 2023

@brentru unblocked

@tyeth tyeth requested a review from brentru September 19, 2023 20:54
@tyeth
Copy link
Contributor Author

tyeth commented Sep 19, 2023

Confused why this is failing but was running locally, I'll take a fresh look tomorrow

Copy link
Member

@brentru brentru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@brentru brentru merged commit 9eaeae9 into adafruit:main Sep 20, 2023
@tyeth tyeth deleted the add-ENS160 branch March 22, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants