Constructor brightness parameter #70
Conversation
changed the animation demo to use it.
…Python_HT16K33 into modify_brightness_property
|
Addresses issue #70 |
geekguy-wy
changed the title
|
The default for the new brightness parameter is the same as it was before this change. There should not be any breakage of code. All current calls will remain the same because the brightness parameter is not required. |
|
Code such as https://github.com/adafruit/Adafruit_Learning_System_Guides/blob/master/BLE_Heart_Rate_Trainer/ble_heart_rate_trainer.py will need to be updated as it would error after this change. |
|
You can still create an instance with the existing parameters. You do not have to add the brightness parameter - the default is the same as before I made this change. If you are talking about the change to using a float instead of an int for the brightness value, then that would break code. |
|
Yes, that's what I was referring to. |
Updating https://github.com/adafruit/Adafruit_CircuitPython_APDS9960 to 2.0.0 from 1.2.7: > Merge pull request adafruit/Adafruit_CircuitPython_APDS9960#19 from caternuson/iss18 Updating https://github.com/adafruit/Adafruit_CircuitPython_CLUE to 2.1.1 from 2.1.0: > Merge pull request adafruit/Adafruit_CircuitPython_CLUE#23 from caternuson/prox_update > update pylintrc for black > build.yml: move pylint, black, and Sphinx installs to each repo; add description to 'actions-ci/install.sh' Updating https://github.com/adafruit/Adafruit_CircuitPython_HT16K33 to 4.0.0 from 3.2.3: > Merge pull request adafruit/Adafruit_CircuitPython_HT16K33#70 from geekguy-wy/constructor_brighness_parameter > Manual merge of adafruit/Adafruit_CircuitPython_HT16K33#63 > update pylintrc for black > Merge pull request adafruit/Adafruit_CircuitPython_HT16K33#69 from makermelissa/set_digit_raw > build.yml: move pylint, black, and Sphinx installs to each repo; add description to 'actions-ci/install.sh'
I added a new brightness=1.0 parameter to the HT16K33 constructor to allow brightness to be set on instantiation. The default is the same as it was before this change to stay consistent and not offer any surprises.