Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set raw digit raise error #63

Closed
wants to merge 11 commits into from
Closed

Set raw digit raise error #63

wants to merge 11 commits into from

Conversation

geekguy-wy
Copy link

Added checking that will raise an error for digit and bitmask value to Seg14x4.set_digit_raw()

Copy link
Contributor

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase

@dhalbert
Copy link
Contributor

dhalbert commented Mar 7, 2020

@makermelissa @geekguy-wy asked in discord about why you wanted a squash. I speculated it was just to reduce the number of commits. Is that right?

@makermelissa
Copy link
Contributor

makermelissa commented Mar 7, 2020

If you go into file changes, you'll notice a new file called examples/ht16k33_animation_demo.py, however that was already added in another PR by @geekguy-wy. It probably doesn't make a difference, but it's harder to review changes when it has duplicate commits.

@geekguy-wy
Copy link
Author

geekguy-wy commented Mar 8, 2020

So, do I or do I not do 'git rebase' in my repo??

makermelissa added a commit that referenced this pull request Mar 9, 2020
@makermelissa
Copy link
Contributor

Closing. Manually merged.

adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Mar 11, 2020
Updating https://github.com/adafruit/Adafruit_CircuitPython_APDS9960 to 2.0.0 from 1.2.7:
  > Merge pull request adafruit/Adafruit_CircuitPython_APDS9960#19 from caternuson/iss18

Updating https://github.com/adafruit/Adafruit_CircuitPython_CLUE to 2.1.1 from 2.1.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_CLUE#23 from caternuson/prox_update
  > update pylintrc for black
  > build.yml: move pylint, black, and Sphinx installs to each repo; add description to 'actions-ci/install.sh'

Updating https://github.com/adafruit/Adafruit_CircuitPython_HT16K33 to 4.0.0 from 3.2.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_HT16K33#70 from geekguy-wy/constructor_brighness_parameter
  > Manual merge of adafruit/Adafruit_CircuitPython_HT16K33#63
  > update pylintrc for black
  > Merge pull request adafruit/Adafruit_CircuitPython_HT16K33#69 from makermelissa/set_digit_raw
  > build.yml: move pylint, black, and Sphinx installs to each repo; add description to 'actions-ci/install.sh'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants