Parse update queries #1354
Merged
Parse update queries #1354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1354 +/- ##
==========================================
+ Coverage 88.77% 88.82% +0.05%
==========================================
Files 324 326 +2
Lines 28676 28850 +174
Branches 3172 3191 +19
==========================================
+ Hits 25456 25627 +171
Misses 2067 2067
- Partials 1153 1156 +3 ☔ View full report in Codecov by Sentry. |
joka921
requested changes
May 22, 2024
There was a problem hiding this comment.
This already looks very promising I am glad that you split this up, that increases the reviewability.
A first round of reviews:
- Comments by me
- Missing tests
- Suggestions by Sonarcloud (the should be const& for
using Base::Baseis a false positive/bug in the tool, but most of the others seem legit.
joka921
requested changes
May 23, 2024
joka921
reviewed
May 31, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit extends SPARQL parser s.t. it can parse SPARQL UPDATE queries and store them as part of the
ParsedQuery. The updates are not yet processed, but (as of now) still lead to an error message that updates are not yet supported.